In file included from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/media/webrtc/signaling/src/media-conduit/Unified_cpp_src_media-conduit0.cpp:38:0: /root/firefox-gcc-last/media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.cpp: In member function 'virtual int32_t mozilla::WebrtcGmpVideoEncoder::InitEncode(const webrtc::VideoCodec*, int32_t, uint32_t)': /root/firefox-gcc-last/media/webrtc/signaling/src/media-conduit/WebrtcGmpVideoCodec.cpp:167:67: error: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'struct webrtc::CodecSpecificInfo'; use assignment or value-initialization instead [-Werror=class-memaccess] memset(&mCodecSpecificInfo, 0, sizeof(webrtc::CodecSpecificInfo)); ^

I don't understand why we do the memset on the entire object since it has a contructor and it initialises the first 2 members? Am i missing something obvious? I think we can only limit to do the memset on the union.

Comment on attachment 8922246 [details] Bug 1411605 - don't memset the entire mCodecSpecificInfo. https://reviewboard.mozilla.org/r/193278/#review198562

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30e090a9e408 don't memset the entire mCodecSpecificInfo. r=dminor