Closed
Bug 1411727
Opened 7 years ago
Closed 7 years ago
Update Debugger Frontend (10-25)
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(2 files, 9 obsolete files)
(deleted),
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8922106 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8922106 -
Attachment is obsolete: true
Attachment #8922106 -
Flags: review?(jdescottes)
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8922108 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8922108 -
Attachment is obsolete: true
Attachment #8922108 -
Flags: review?(jdescottes)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8922110 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8922110 -
Attachment is obsolete: true
Attachment #8922110 -
Flags: review?(jdescottes)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8922112 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8922112 -
Attachment is obsolete: true
Attachment #8922112 -
Flags: review?(jdescottes)
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8922113 -
Flags: review?(jdescottes)
Assignee | ||
Updated•7 years ago
|
Attachment #8922113 -
Attachment is obsolete: true
Attachment #8922113 -
Flags: review?(jdescottes)
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8922114 -
Flags: review?(jdescottes)
Assignee | ||
Comment 8•7 years ago
|
||
seeing an issue w/ the wasm test...
Updated•7 years ago
|
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 58
Version: 57 Branch → unspecified
Updated•7 years ago
|
Blocks: debugger-bundle-updates
Assignee | ||
Comment 10•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8922114 -
Attachment is obsolete: true
Attachment #8922114 -
Flags: review?(jdescottes)
Assignee | ||
Comment 11•7 years ago
|
||
Attachment #8922851 -
Flags: review?(jdescottes)
Assignee | ||
Comment 12•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8922851 -
Attachment is obsolete: true
Attachment #8922851 -
Flags: review?(jdescottes)
Assignee | ||
Comment 13•7 years ago
|
||
Attachment #8922874 -
Flags: review?(jdescottes)
Assignee | ||
Comment 14•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8922874 -
Attachment is obsolete: true
Attachment #8922874 -
Flags: review?(jdescottes)
Assignee | ||
Comment 15•7 years ago
|
||
Attachment #8922903 -
Flags: review?(jdescottes)
Assignee | ||
Comment 16•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8922903 -
Attachment is obsolete: true
Attachment #8922903 -
Flags: review?(jdescottes)
Assignee | ||
Comment 17•7 years ago
|
||
Attachment #8922939 -
Flags: review?(jdescottes)
Comment 18•7 years ago
|
||
With the new patch, the disabled icons for stepping are almost impossible to differentiate from the enabled ones.
Comment 19•7 years ago
|
||
Comment 20•7 years ago
|
||
Comment on attachment 8922939 [details] [diff] [review]
patch-10-25-7.patch
Review of attachment 8922939 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, just one issue with the disabled icons (see previous comment + screenshot).
Up to you if you want to fix it here or not.
::: devtools/client/debugger/new/README.mozilla
@@ +1,4 @@
> This is the debugger.html project output.
> See https://github.com/devtools-html/debugger.html
>
> +Taken from upstream commit: d9f18b2cd0792de70289d4dcde5ed3e38be87cf1
We discussed this on slack, but for the record: a good evolution for this would be to add the actual link to the debugger commit on GitHub. Even better would be to have a link to the compare view between this commit and the previous release commit.
Finally this information could also be added to the commit message (this way people who don't know about this file could still get the information easily.
Attachment #8922939 -
Flags: review?(jdescottes) → review+
Assignee | ||
Comment 21•7 years ago
|
||
Lets push this patch and we'll fix the disable state in GH and patch on monday.
Thanks for the updates on the readme, i made an issue for it here: https://github.com/jasonLaster/ship2gecko/issues/2
Comment 22•7 years ago
|
||
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/129dfaaf265a
Update Debugger frontend (10-25). r=jdescottes
Comment 23•7 years ago
|
||
bugherder |
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•