nhottanscp Assignee
	Description • 23 years ago

nsIPlatformCharset provides a selector "kPlatformCharsetSel_KeyboardInput" which
is supposed to return a charset name based on the currently active keyboard script.
http://lxr.mozilla.org/seamonkey/source/intl/uconv/public/nsIPlatformCharset.h

Currenty, there is no implementation for "kPlatformCharsetSel_KeyboardInput".
http://lxr.mozilla.org/seamonkey/search?string=nsPlatformCharset%3A%3AGetCharset

	Rui Xu
	Comment 1 • 23 years ago

QA -> yokoyama for the code implementation, feel free to reassign it back to IQA 
in case you need IQA's help.

	Frank Tang
	Comment 4 • 23 years ago

Comment on attachment 81919 [details] [diff] [review]
change line breaks of the patch

r=ftang
please make sure you 0x00FFF & with the return value of
GetScriptManagerVariable(smKeyScript), 
I remember there was some problem if I don't do that. CAnnot remember what is
broken without it.

	nhottanscp Assignee
	Comment 6 • 23 years ago

Comment on attachment 82095 [details] [diff] [review]
Changed to address ftang's comment.

copy 'r='

	Brendan Eich [:brendan]
	Comment 7 • 22 years ago

Comment on attachment 82095 [details] [diff] [review]
Changed to address ftang's comment.

rs=brendan@mozilla.org if you:

- break the overlong line in the case kPlatformCharsetSel_KeyboardInput;
statement so it wraps nicely within 80 columns;

- put a break; after the default: case's statement, in case someone some day
adds a case at the end.

/be

	nhottanscp Assignee
	Comment 9 • 22 years ago

Comment on attachment 84462 [details] [diff] [review]
Address super reviewer's comment.

copy 'r' and 'sr'

	nhottanscp Assignee
	Comment 10 • 22 years ago

checked in to the trunk

I make this bug as Macintosh specific and open a separate XP bug.

	nhottanscp Assignee
	Comment 11 • 22 years ago

verified

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsMacCharset.cpp&root=/cvsroot&subdir=mozilla/intl/uconv/src&command=DIFF_FRAMESET&rev1=1.27&rev2=1.28