colors.bookmark_text is supported in chrome. I think it makes sense to support bookmark_text as an alias for toolbar_text as it work better for compatibility with chrome.

Comment on attachment 8923765 [details] Bug 1412595 - Implement colors.bookmark_text as alias for colors.toolbar_text. https://reviewboard.mozilla.org/r/194912/#review201540 ::: toolkit/components/extensions/ext-theme.js:137 (Diff revision 2) > case "toolbar_text": > + case "bookmark_text": > + this.lwtStyles.toolbar_text = cssColor; But which color should win if both are specified? Right now the code will treat the *last* specified as the used color, this may be confusing to people who port over their theme from Chrome.

Comment on attachment 8923765 [details] Bug 1412595 - Implement colors.bookmark_text as alias for colors.toolbar_text. https://reviewboard.mozilla.org/r/194912/#review201952

Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b4a8921258e0 Implement colors.bookmark_text as alias for colors.toolbar_text. r=jaws

I can reproduce this issue on Firefox 57.0 (20171112125346) under Wind 7 64-bit. This issue is verified as fixed on Firefox 59.0a1 (20171120100042) and Firefox 58.0b4 (20171115114231) under Wind 7 64-bit and Mac OS X 10.13. Using "bookmark_text": "#7206F5" will color the text of the tab in focus and the toolbar icons. Please see the attached video.

I noticed that if you use bookmark_text and toolbar_text together, the color from toolbar_text will be always picked, no matter in what order they are used. Is this expected? Or I should file another bug?

Seems like a reasonable behaviour for now. Bug 1415209 will polish this.

I've updated https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/theme for this, please let me know if this covers it.

Works for me, thanks!