Closed Bug 1412644 Opened 7 years ago Closed 6 years ago

[Static Analysis] Uninitialized fields in some classes of widget

Categories

(Core :: Widget, defect, P3)

Product:
Core
Component:
Widget
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1453795

People

(Reporter: tristanbourvon, Assigned: tristanbourvon)

References

Details

(Keywords: csectype-uninitialized, sec-moderate)

Attachments

(1 file, 1 obsolete file)

widget.patch
(deleted), patch
jimm
: review+
Details | Diff | Splinter Review 
As part of the static analysis effort to ensure all class fields are initialized before usage (see https://bugzilla.mozilla.org/show_bug.cgi?id=525063), here are a few fixes to the widget module.
By the way, who should I r? for the patch?
Blocks: 1411595
Assignee: nobody → tristanbourvon
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attached patch widget.patch (deleted) — — Splinter Review 
Fix some coding style issues.
Attachment #8923162 - Attachment is obsolete: true
Priority: -- → P3
Attachment #8923763 - Flags: review?(jmathies)
Group: core-security → layout-core-security
Attachment #8923763 - Flags: review?(jmathies) → review+
What are the next steps here?  Can we land this patch?
Flags: needinfo?(tristanbourvon)
Flags: needinfo?(jmathies)
I can take a look at it in a few days.
Flags: needinfo?(tristanbourvon)
Flags: needinfo?(jmathies)
So after taking a look at this, it seems that everything was fixed in the large bundle of fixes from 1453795.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Great! Thanks for looking into it.
Group: layout-core-security → core-security-release
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: