Closed
Bug 1412648
Opened 7 years ago
Closed 7 years ago
[Static Analysis] Uninitialized fields in some classes of tools/profiler
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: tristanbourvon, Assigned: tristanbourvon)
References
Details
(Whiteboard: [adv-main58+])
Attachments
(1 file)
|
(deleted),
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
As part of the static analysis effort to ensure all class fields are initialized before usage (see https://bugzilla.mozilla.org/show_bug.cgi?id=525063), here are a few fixes to the tools/profiler module.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8923166 -
Flags: review?(mstange)
|
||
Updated•7 years ago
|
Assignee: nobody → tristanbourvon
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8923166 [details] [diff] [review]
tools_profiler.patch
Review of attachment 8923166 [details] [diff] [review]:
-----------------------------------------------------------------
::: tools/profiler/core/ProfilerMarker.h
@@ +27,5 @@
> double aTime = 0)
> : mMarkerName(strdup(aMarkerName))
> , mPayload(Move(aPayload))
> + , mNext{nullptr}, mTime(aTime)
> + , mGenID{0} {}
separate lines + bad indent
::: tools/profiler/core/platform.cpp
@@ +2498,3 @@
> }
> AutoSetProfilerEnvVarsForChildProcess::AutoSetProfilerEnvVarsForChildProcess(
> + MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL) : mSetEntries(), mSetInterval(), mSetFeaturesBitfield(), mSetFilters()
These need to go on separate lines. Please follow the example at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Classes .
Attachment #8923166 -
Flags: review?(mstange) → review+
|
|
||
Comment 3•7 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → wontfix
status-firefox57:
--- → wontfix
status-firefox58:
--- → fixed
status-firefox-esr52:
--- → wontfix
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
Group: core-security → core-security-release
|
||
Updated•7 years ago
|
Whiteboard: [adv-main58+]
|
|
||
Updated•6 years ago
|
Group: core-security-release
You need to log in
before you can comment on or make changes to this bug.
Description
•