Closed
Bug 1412888
Opened 7 years ago
Closed 7 years ago
bump the sccache revision to include argument parsing fixes
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
Details
Attachments
(1 file)
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
We've added some argument parsing fixes to sccache that are necessary to
improve cacheability of requests. This bump was rs+'d by Ted on #build:
12:26 PM <@ted> froydnj: are you going to bump the sccache version in m-c?
12:26 PM — @ted actually reading bugmail
12:27 PM <froydnj> ted: oh, that's right, we have git hashes, I thought you were going to need to do a minor release
12:27 PM <@ted> nah
12:27 PM <froydnj> ted: sure, I will bump that
12:27 PM <@ted> froydnj: rs=me if you don't want to jump through hoops
Attachment #8923471 -
Flags: review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15df5665d779
bump the sccache revision to include argument parsing fixes; r=ted.mielczarek
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44b8d2bb1ec0
increase the sccache idle timeout for Android/x86 jobs; r=ted.mielczarek
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef4f0721733f
fix for super-flexible data formats; r=me
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/15df5665d779
https://hg.mozilla.org/mozilla-central/rev/44b8d2bb1ec0
https://hg.mozilla.org/mozilla-central/rev/ef4f0721733f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Comment 6•7 years ago
|
||
bugherder |
Comment 7•7 years ago
|
||
This alert showed up. It looks like one platform wasn't entirely fixed.
== Change summary for alert #10281 (as of November 01 2017 00:44 UTC) ==
Regressions:
64% sccache requests_not_cacheable summary android-4-2-x86 opt taskcluster-m4.2xlarge 16.46 -> 27.00
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=10281
Updated•7 years ago
|
Flags: needinfo?(nfroyd)
Comment 8•7 years ago
|
||
Is this something we should accept? Or must I reopen this bug?
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #7)
> This alert showed up. It looks like one platform wasn't entirely fixed.
>
> == Change summary for alert #10281 (as of November 01 2017 00:44 UTC) ==
>
> Regressions:
>
> 64% sccache requests_not_cacheable summary android-4-2-x86 opt
> taskcluster-m4.2xlarge 16.46 -> 27.00
>
> For up to date results, see:
> https://treeherder.mozilla.org/perf.html#/alerts?id=10281
We fixed the majority of non cacheable requests by fixing sccache's argument parsing, but there are still *more* non-cacheable requests showing up than before we switched to clang? Are we executing more configure checks with clang, perhaps? I don't know how this could possibly happen otherwise.
Ted, is it possible to get a breakdown of all the non-cacheable requests for more insight into these numbers?
Flags: needinfo?(nfroyd) → needinfo?(ted)
Comment 10•7 years ago
|
||
If you change the logging options you should be able to find this in sccache.log, which gets uploaded as a build artifact. By default we use `RUST_LOG=sccache::compiler=debug`, but you could use `RUST_LOG=sccache::compiler=debug,sccache::server=debug` which will enable debug logging in server.rs, which logs the result of `parse_arguments`:
https://github.com/mozilla/sccache/blob/cbb72b80df248eed18b399da7e0d77cbaedb3b07/src/server.rs#L497
Flags: needinfo?(ted)
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•