Closed
Bug 1413609
Opened 7 years ago
Closed 7 years ago
Remove Mozilla specific options as they have been merged upstream
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
A few options in .clang-format are no longer useful because they have been enabled in clang-format upstream.
We should remove them.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8925365 [details]
Bug 1413609 - Remove Mozilla specific options as they have been merged upstream
https://reviewboard.mozilla.org/r/196514/#review201790
Attachment #8925365 -
Flags: review?(bpostelnicu) → review+
|
||
Comment 4•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 7cdc747db6ac -d 25f6ee53ac1c: rebasing 432241:7cdc747db6ac "Bug 1413609 - Remove Mozilla specific options as they have been merged upstream r=andi" (tip)
merging .clang-format
warning: conflicts while merging .clang-format! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
| Comment hidden (mozreview-request) |
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f43442328ed9
Remove Mozilla specific options as they have been merged upstream r=andi
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Comment 8•7 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #0)
> A few options in .clang-format are no longer useful because they have been
> enabled in clang-format upstream.
in which version?
|
Assignee | |
Comment 9•7 years ago
|
||
5.0 has all of them
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•