Closed
Bug 1413840
Opened 7 years ago
Closed 7 years ago
[dt-onboarding] Add links to MDN for each feature presented in about:devtools
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
After enabling DevTools, about:devtools shows a grid of features (inspector, debugger, etc).
We should add a learn more feature in each section that links to the MDN page for the feature. The feature icon should also become a link that leads to the same MDN page.
Assignee | ||
Updated•7 years ago
|
Blocks: 1408339, dt-onboarding
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8924741 [details]
Bug 1413840 - add a link to MDN on each about:devtools feature;
https://reviewboard.mozilla.org/r/195972/#review201800
Attachment #8924741 -
Flags: review?(nchevobbe) → review+
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Assignee | ||
Comment 5•7 years ago
|
||
Thanks for the review Nicolas! Adding r? to :flod to check the new properties file devtools/shim/locales/en-US/aboutdevtools.properties
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8924741 [details]
Bug 1413840 - add a link to MDN on each about:devtools feature;
https://reviewboard.mozilla.org/r/195972/#review201854
::: devtools/shim/locales/en-US/aboutdevtools.properties:12
(Diff revision 3)
> +# LOCALIZATION NOTE (features.learnMore): The text of the learn more link displayed below
> +# each feature section of about:devtools. Each section presents a quick description of a
> +# DevTools panel/feature. The learn more link points to the associated MDN page.
> +features.learnMore=Learn more
> +
> +# LOCALIZATION NOTE (features.inspector.title): Title for the feature section about the
I think we should get rid of the l10n comments for these two strings: the ID is clear enough, and we don't have them for all the other elements.
Attachment #8924741 -
Flags: review?(francesco.lodolo) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
Thanks for the review. Removed the comments features.inspector.title/desc.
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15232bc44448
add a link to MDN on each about:devtools feature;r=flod,nchevobbe
Comment 10•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•