Closed
Bug 1413844
Opened 7 years ago
Closed 7 years ago
[dt-onboarding] Add UTM parameters to all about:devtools external links
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926953 [details]
Bug 1413844 - add utm parameters to about:devtools links;
https://reviewboard.mozilla.org/r/198198/#review203790
::: devtools/shim/aboutdevtools/aboutdevtools.js:195
(Diff revision 2)
> }
>
> + // Add Google Analytics parameters to all the external links.
> + let externalLinks = [...document.querySelectorAll("a.external")];
> + for (let link of externalLinks) {
> + let href = link.getAttribute("href") + "?" + GA_PARAMETERS;
Are we certain none of these links already contain request parameters?
Attachment #8926953 -
Flags: review?(pbrosset) → review+
| Comment hidden (mozreview-request) |
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6bb75646859
add utm parameters to about:devtools links;r=pbro
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•