Doug Thayer [:dthayer] (he/him) Assignee
	Description • 7 years ago

This breaks our retry logic in Chrome migrations.

	Matthew N. [:MattN]
	Comment 1 • 7 years ago

The setTimout was originally added in bug 1285041 in ChromeProfileMigrator.js and was moved to MigrationUtils.jsm in bug 1305770.

Doug, I see you're assigned, are you working on this?

You should just be able to import Timer.jsm. Testing it will be more difficult as you'll need to force an exception. See the test_Chrome* files in https://dxr.mozilla.org/mozilla-central/source/browser/components/migration/tests/unit

	:Gijs (he/him)
	Comment 2 • 7 years ago

Ugh, I am dumb sometimes. How isn't this failing eslint? :-(

	:Gijs (he/him)
	Comment 3 • 7 years ago

I also wonder if this is the cause of https://bugzilla.mozilla.org/show_bug.cgi?id=1332225#c34 .

	Mark Banner (:standard8)
	Comment 4 • 7 years ago

(In reply to :Gijs (slow, PTO recovery mode) from comment #2)
> Ugh, I am dumb sometimes. How isn't this failing eslint? :-(

That's bug 1369722. With the ESLint 4 upgrade next week, it'll be possible that we can do it in a sane way now.

	Doug Thayer [:dthayer] (he/him) Assignee
	Comment 5 • 7 years ago

(In reply to :Gijs (slow, PTO recovery mode) from comment #3)
> I also wonder if this is the cause of
> https://bugzilla.mozilla.org/show_bug.cgi?id=1332225#c34 .

I couldn't find a way for this to result in the migrator hanging. Forcing an error in order to hit this block just resulted in nothing being imported.

(In reply to Matthew N. [:MattN] (PM if requests are blocking you) from comment #1)
> The setTimout was originally added in bug 1285041 in
> ChromeProfileMigrator.js and was moved to MigrationUtils.jsm in bug 1305770.
> 
> Doug, I see you're assigned, are you working on this?
> 
> You should just be able to import Timer.jsm. Testing it will be more
> difficult as you'll need to force an exception. See the test_Chrome* files
> in
> https://dxr.mozilla.org/mozilla-central/source/browser/components/migration/
> tests/unit

Woops. I filed this while in the middle looking into the performance of migrations and promptly forgot I had created it and also assigned myself. But yes, I intended to work on it and I'll get a patch up shortly.

	Matthew N. [:MattN]
	Comment 7 • 7 years ago
mozreview-review

Comment on attachment 8926146 [details]
Bug 1413989 - include Timer.jsm in MigrationUtils.jsm

https://reviewboard.mozilla.org/r/197384/#review202640

	Matthew N. [:MattN]
	Comment 8 • 7 years ago

Thanks

	Pulsebot
	Comment 9 • 7 years ago

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7d8c4617ad28
include Timer.jsm in MigrationUtils.jsm r=MattN

	Pulsebot
	Comment 10 • 7 years ago

Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c8659b2921a
Backed out 1 changesets for ESLint failure "browser/components/migration/tests/unit/test_MigrationUtils_timedRetry.js" r=backout on a CLOSED TREE

	:Gijs (he/him)
	Comment 11 • 7 years ago

(In reply to Pulsebot from comment #10)
> Backout by nbeleuzu@mozilla.com:
> https://hg.mozilla.org/integration/autoland/rev/0c8659b2921a
> Backed out 1 changesets for ESLint failure
> "browser/components/migration/tests/unit/test_MigrationUtils_timedRetry.js"
> r=backout on a CLOSED TREE

Welp, that will teach me to be pushing other people's patches - sorry!

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 12 • 7 years ago

Too late for 57 but we could still take this patch for 58.

	Doug Thayer [:dthayer] (he/him) Assignee
	Comment 13 • 7 years ago

(In reply to :Gijs (slow, PTO recovery mode) from comment #11)
> Welp, that will teach me to be pushing other people's patches - sorry!

Eh, my bad for not habitually linting it before pushing to review.

	Pulsebot
	Comment 15 • 7 years ago

Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d0280b48ef58
include Timer.jsm in MigrationUtils.jsm r=MattN

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 16 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d0280b48ef58