Closed
Bug 1413993
Opened 7 years ago
Closed 7 years ago
Declaration of USEC_PER_SEC conflicts with #define on MacOS
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
jya
:
review+
|
Details | Diff | Splinter Review |
The changes in bug 1410132 trigger a compile error in dom/media/mediasource/ContainerParser.cpp on MacOS due to causing mach/clock_types.h to be included, which #defines USEC_PER_SEC.
https://treeherder.mozilla.org/logviewer.html#?job_id=141701516&repo=mozilla-inbound&lineNumber=15466
Fortunately this constant doesn't seem to be used anywhere so I think we can just remove it.
Attachment #8924623 -
Flags: review?(jyavenard)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8924623 [details] [diff] [review]
remove-conflicting-const
Review of attachment 8924623 [details] [diff] [review]:
-----------------------------------------------------------------
Please change the commit title to:
Remove unused USEC_PER_SEC constant
And in the details explain on the why (conflict and so forth)
Thank you.
Attachment #8924623 -
Flags: review?(jyavenard) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79def5ebdec2
Remove unused USEC_PER_SEC constant r=jya
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•