Closed
Bug 1414224
Opened 7 years ago
Closed 6 years ago
Investigate removing the fetch in getTransactionsForTransferItems when dropping/pasting bookmarks
Categories
(Firefox :: Bookmarks & History, enhancement, P1)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
We currently have a bookmarks fetch in getTransactionsForTransferItems. We should try to avoid this if possible for performance reasons as it is causing extra reads from the disk.
Marco's comments from bug 1410940 comment 4:
Yesterday on IRC we discussed about the case where a user may copy something, make changes, then paste. That's an edge case that may prevent us from just storing the info on copy. I suggested checking if we can pass out the container node from the view.insertionPoint getter, and gather info out of it instead.
Assignee | ||
Comment 1•7 years ago
|
||
Currently, bug 1404909 *may* be removing this additional fetch.
Depends on: 1404909
Assignee | ||
Comment 2•6 years ago
|
||
After bug 1404909, we no longer have the fetch, but I've just realised that the functions are still marked as async, so we might as well clean that up.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment 3•6 years ago
|
||
MozReview-Commit-ID: 4XEv3IO5YvB
Comment 4•6 years ago
|
||
Comment on attachment 8984946 [details]
Bug 1414224 - Remove unnecessary async annotations around getTransactionsForTransferItems.
Marco Bonardo [::mak] has approved the revision.
https://phabricator.services.mozilla.com/D1611
Attachment #8984946 -
Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e49d6288bd3c
Remove unnecessary async annotations around getTransactionsForTransferItems. r=mak
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Updated•6 years ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•