User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0 Build ID: 20171103100331 Steps to reproduce: Select a new theme for Fennec Nightly 2017-11-03. Choose a light gray colour. I tried "Linen Light" and "Mac OSX Light" Open a Private Browsing tab Type in the Awesomebar The Awesomebar text is white on a light gray background and is very hard to read I suggest that Private Browsing should not emulate the Theme colour in the text field

I think this might be a side effect of bug 1389164, but given that we don't actually style the toolbar in private mode, the changed background isn't actually required there.

Hi Carol. Please help advise

I attached a screenshot to make sure we're talking about the same thing. Since we don't apply LWT to the private tab, I'll suggest removing the light grey bg on the tool bar for the private tab. Nevin, let me know if there will be any concerns removing the box bg. thank you :)

(In reply to Carol Huang [:Carol] from comment #4) > I attached a screenshot to make sure we're talking about the same thing. > Since we don't apply LWT to the private tab, I'll suggest removing the light > grey bg on the tool bar for the private tab. Yup, that's the thing I mean.

Comment on attachment 8938664 [details] Bug 1414309 - Tell ToolbarEditLayout's title background about private mode changes. https://reviewboard.mozilla.org/r/209270/#review215668

LGTM. Thanks!

Pushed by mozilla@buttercookie.de: https://hg.mozilla.org/integration/autoland/rev/da52ff7129ad Tell ToolbarEditLayout's title background about private mode changes. r=nechen

Pushed by apavel@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/bfdc585f72b3 Tell ToolbarEditLayout's title background about private mode changes. r=nechen

Comment on attachment 8938664 [details] Bug 1414309 - Tell ToolbarEditLayout's title background about private mode changes. Approval Request Comment [Feature/Bug causing the regression]: bug 1389164 [User impact if declined]: If a theme has been installed, text entered into the URL bar during private browsing will be harder to read because of the light background [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: Tested locally. [Needs manual test from QE? If yes, steps to reproduce]: No. [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: No. [Why is the change risky/not risky?]: Small changes to disable the light background in private mode, doing the same thing that already happens when the URL bar doesn't have the input focus. [String changes made/needed]: no

Comment on attachment 8938664 [details] Bug 1414309 - Tell ToolbarEditLayout's title background about private mode changes. A UI enhancement. Beta58+. Hi Ioana, could you help find someone to verify if this issue was fixed as expected on the latest Nightly build? Thanks!

Verified as fixed in Nightly 59 (2018-01-08). Devices: Google Pixel (Android 8.0) Oneplus Two (Android 6.0.1)

Verified as fixed in build 58.0b17. Devices: Google Pixel (Android 8.0), Huawei MediaPad M2 (Android 5.1.1), Samsung Galaxy Tab 3 (Android 7.0).