Closed
Bug 1414834
Opened 7 years ago
Closed 7 years ago
Re-land print IPC changes so that the child doesn't open files
Categories
(Core :: Security: Process Sandboxing, enhancement, P1)
Core
Security: Process Sandboxing
Tracking
()
RESOLVED
FIXED
mozilla59
People
(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)
References
(Blocks 1 open bug)
Details
(Whiteboard: sb+)
Attachments
(1 file, 1 obsolete file)
Specifically, re-land part 3 of bug 1319423. It was reverted in bug 1412643.
Relanding this will include changes to print selection so that we don't cause the bug which was reported there.
Assignee | ||
Updated•7 years ago
|
Priority: -- → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
I plan to get onto this tomorrow.
Updated•7 years ago
|
Whiteboard: sb+
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8925540 [details]
Bug 1414834 - re-land print IPC changes from bug 1319423;
https://reviewboard.mozilla.org/r/196662/#review203716
::: layout/printing/ipc/PRemotePrintJob.ipdl:52
(Diff revision 1)
> // Inform the child that the print has been initialized in the parent or has
> - // failed with result aRv.
> - async PrintInitializationResult(nsresult aRv);
> -
> - // Inform the child that the latest page has been processed remotely.
> - async PageProcessed();
> + // failed with result aRv. Includes a file descriptor which the first page
> + // can be written to.
> + async PrintInitializationResult(nsresult aRv, FileDescriptor aFd);
> +
> + // Inform the child that the latest page has been processed remotely. Inclues
nit: s/Inclues/Includes/
::: layout/printing/ipc/RemotePrintJobChild.cpp:51
(Diff revision 1)
> + SetNextPageFD(aFd);
> + }
> return IPC_OK();
> }
>
> +PRFileDesc* RemotePrintJobChild::GetNextPageFD() {
nit: return type on previous line, curly bracket on following line.
::: layout/printing/ipc/RemotePrintJobParent.cpp:94
(Diff revision 1)
> }
>
> return NS_OK;
> }
>
> +nsresult RemotePrintJobParent::PrepareNextPageFD(FileDescriptor* aFd) {
nit: return type on previous line, curly bracket on following line.
Attachment #8925540 -
Flags: review?(bobowencode) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8925539 [details]
Bug 1414834 - Part 1 - made print selection go through the print timer;
https://reviewboard.mozilla.org/r/196660/#review203758
I've filed bug 1419739 to handle this separately as I'm not sure how well mozreview will play with a different patch.
Attachment #8925539 -
Flags: review?(bobowencode)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8925539 -
Attachment is obsolete: true
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 10•7 years ago
|
||
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/87f5eb24ef4b
re-land print IPC changes from bug 1319423; r=bobowen
Keywords: checkin-needed
Comment 11•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•