Closed Bug 1414961 Opened 7 years ago Closed 5 years ago

Add support to ANGLE for EXT_blend_func_extended on D3D11

Categories

(Core :: Graphics: WebRender, enhancement, P2)

Product:
Core
Component:
Graphics: WebRender
Platform:
Unspecified
Windows
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox57 --- unaffected
firefox58 --- unaffected
firefox68 --- fixed

People

(Reporter: jrmuizel, Assigned: lsalzman)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [wr-reserve][wr-q2][wr-april])

Attachments

(2 files)

Bug 1414961 - check for EXT_blend_func_extended when using GL ES. r?gw
(deleted), text/x-phabricator-request
Details
Bug 1414961 - enable WR dual-source blending by default. r?jrmuizel
(deleted), text/x-phabricator-request
Details
See https://chromium-review.googlesource.com/c/angle/angle/+/287580. It would be good to get this upstreamed directly.
Whiteboard: [wr-mvp] [triage]
I believe we should be able to have this extension available everywhere we get ES3 through ANGLE. ANGLE requires 10.1 hardware for ES3. Dual source blending is required for 10.1 hardware.
Blocks: stage-wr-nightly
status-firefox57: --- → unaffected
status-firefox58: --- → unaffected
Whiteboard: [wr-mvp] [triage] → [wr-mvp] [triage][wr-reserve-candidate]
Priority: -- → P3
Whiteboard: [wr-mvp] [triage][wr-reserve-candidate] → [wr-reserve]
No longer blocks: stage-wr-nightly
Assignee: nobody → lsalzman
Blocks: wr-68
Blocks: wr-intel

There was an original patch that added some support in 2016 but was backed out.

It was relanded in https://chromium-review.googlesource.com/1233713.

This was further improved in https://chromium-review.googlesource.com/c/1249361

Summary: Add support to ANGLE for EXT_blend_func_extended → Add support to ANGLE for EXT_blend_func_extended on D3D11

So we'll need to add D3D backend support and HLSL translation support.

Whiteboard: [wr-reserve] → [wr-reserve][wr-q2][wr-april]
Depends on: angle-68
Keywords: leave-open
OS: Unspecified → Windows
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2c91afc264b check for EXT_blend_func_extended when using GL ES. r=gw
Depends on: angle-68-3
No longer depends on: angle-68
Keywords: leave-open
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52da0d93fe09 enable WR dual-source blending by default. r=jrmuizel

https://hg.mozilla.org/mozilla-central/rev/52da0d93fe09

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: