Open
Bug 1415230
Opened 7 years ago
Updated 2 years ago
Add MOZ_CAN_RUN_SCRIPT annotations to things that can
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Tracking
()
NEW
People
(Reporter: bzbarsky, Unassigned)
References
(Depends on 23 open bugs, Blocks 1 open bug)
Details
Attachments
(1 obsolete file)
The idea is that things annotated MOZ_CAN_RUN_SCRIPT must have the caller holding on-stack strong refs to all refcounted arguments, including "this". We added a static analysis for this in bug 1380423, but now we should actually use this annotation.
This is a tracking bug for this work. I'll file some dependencies in a few minutes.
Comment 1•7 years ago
|
||
bz asked for something like this for testing on IRC, so I threw together a patch.
MozReview-Commit-ID: 2YKncUdrT5p
Comment 2•7 years ago
|
||
I've looked into something like this, based on adapting the GC rooting static analysis, but the way the GC rooting analysis is set up, you'd have to change the types of all of the raw pointer arguments to a type that explicitly roots, which seemed impractical.
Updated•7 years ago
|
Priority: -- → P2
Reporter | ||
Comment 3•7 years ago
|
||
Nika, do you mind landing that opt-out in a separate bug? I think it will make it a _lot_ simpler to incrementally annotate things with MOZ_CAN_RUN_SCRIPT...
Flags: needinfo?(nika)
Comment 4•7 years ago
|
||
Filed bug 1418465.
Updated•7 years ago
|
Flags: needinfo?(nika)
Updated•7 years ago
|
Attachment #8926010 -
Attachment is obsolete: true
Assignee | ||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
Updated•6 years ago
|
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•