Closed
Bug 1415340
Opened 7 years ago
Closed 7 years ago
status is not defined in GMPDownloader.start()
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: standard8, Assigned: spohl)
References
Details
Attachments
(1 file)
(deleted),
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
Picked up via lint whilst starting to investigate bug 1369722. http://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/toolkit/modules/GMPInstallManager.jsm#432 status is undefined. It looks like it has been that way since the code was introduced in bug 1009816. AFAICT there's no functional effect here, as the results of the rejected promise aren't used from what I see. I'm not sure what the original intent was though.
Assignee | ||
Comment 1•7 years ago
|
||
From the looks of it, |status| was intended for HTTP status codes, of which we don't have any in this case. This must have been copy/pasted from one of the other rejected Promises and never removed.
Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED
Attachment #8926179 -
Flags: review?(gfritzsche)
Updated•7 years ago
|
Attachment #8926179 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 2•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fa423b95ce4c40101046f0b3d382b61a1293f3e Bug 1415340: Remove undefined (and unnecessary) property when rejecting a Promise in GMPDownloader. r=gfritzsche
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5fa423b95ce4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in
before you can comment on or make changes to this bug.
Description
•