It looks like MozillaBuild 3.1 failed to pick up bug 1383578.

The patch from bug 1383578 is very-much there. https://hg.mozilla.org/mozilla-build/rev/115a88792b1a You're saying it's not working for you? Remind me again of why I even care about this LLVM code anymore? This seems like a rat's nest of trouble that isn't worth having.

Wait, from your comment in bug 1383578, you're seeing the older version of start-shell.bat still?! That's not what I'm seeing locally: > SET "PATH=%PATH%;!LLVMDIR!\bin" And I've verified again with a fresh install to a brand new directory using the released version of the installer that it's still what I'm seeing.

I don't see this issue locally. FWIW, LLVM detection was initially added in bug 1238251. IIRC we install a clang in bootstrap for stylo, does that include llvm? If so, we probably don't really care about llvm in system for Windows, I suppose.

I deleted mozilla-build then ran the installer I downloaded from https://ftp.mozilla.org/pub/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe and I still see SET PATH="%PATH%;!LLVMDIR!\bin" Perhaps a proxy server somewhere is caching the MozillaBuild installer.

FWIW I downloaded the installer again to double-check and I still see the same result.

proxy server shouldn't be injecting into https connection unless you explicit allows it...

Looking at the binary it seems to be the same as the MozillaBuild 3.0 one. I'm not sure where the caching is happening.

Note that the installer explicitly identifies itself as version 3.1 when you run it. You can also double-check the sha256 for it: 942d968b17262a517f55c2da3cf01ac5651420d4f8f9a668090f5275af106aca

I confirm that in MozillaBuild 3.1 I see: SET "PATH=%PATH%;!LLVMDIR!\bin" I had downloaded directly from: https://ftp.mozilla.org/pub/mozilla/libraries/win32/MozillaBuildSetup-3.1.exe and not used: https://ftp.mozilla.org/pub/mozilla/libraries/win32/MozillaBuildSetup-Latest.exe

Thanks -- using the versioned link works for me. No matter how many times I download MozillaBuildSetup-Latest.exe I still get version 3.0.

FWIW, I downloaded both the -3.1 and -Latest installers and verified their hashes before posting the official announcements. But I guess it could still be S3 caching being crappy somewhere too.

Seems to be fixed after downloading the versioned installer. Perhaps it might be better to link to the versioned installer in future. Sorry for the hassle.

This seems to work now, it must have been cached somewhere. Updating the title.