This is a follow up bug of bug 1408227.

s/bug 1408227/bug 1406482

Comment on attachment 8926825 [details] Bug 1415509 - part 1: EditorBase::FindBetterInsertionPoint() should take an EditorRawDOMPoint argument for input and return EditorRawDOMPoint for the result https://reviewboard.mozilla.org/r/198072/#review203604

Comment on attachment 8926826 [details] Bug 1415509 - part 2: EditorBase::InsertTextImpl() should take |const EditorRawDOMPoint&| argument as input and |EditorRawDOMPoint*| as out argument instead of a set of container, child and offset of the child in the container as in/out argument https://reviewboard.mozilla.org/r/198074/#review203626 ::: editor/libeditor/HTMLEditRules.cpp:1538 (Diff revision 1) > - if (curNode) { > - aSelection->Collapse(curNode, curOffset); > + > + if (currentPoint.IsSet()) { > + ErrorResult error; > + aSelection->Collapse(currentPoint.AsRaw(), error); > + if (error.Failed()) { > + NS_WARNING("Failed to collapse at current point"); Is error.SuppressException() unnecessary for assertion?

Comment on attachment 8926826 [details] Bug 1415509 - part 2: EditorBase::InsertTextImpl() should take |const EditorRawDOMPoint&| argument as input and |EditorRawDOMPoint*| as out argument instead of a set of container, child and offset of the child in the container as in/out argument https://reviewboard.mozilla.org/r/198074/#review203626 > Is error.SuppressException() unnecessary for assertion? Oh, good catch!

Comment on attachment 8926827 [details] Bug 1415509 - part 3: WSRunObject::InsertText() should take |const EditorRawDOMPoint&| as input argument and |EditorRawDOMPoint*| as out argument instead of a set of container, child and offset of the child in the container as in/out argument https://reviewboard.mozilla.org/r/198076/#review203634

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/e3d5220206fc part 1: EditorBase::FindBetterInsertionPoint() should take an EditorRawDOMPoint argument for input and return EditorRawDOMPoint for the result r=m_kato https://hg.mozilla.org/integration/autoland/rev/c6844ea5e019 part 2: EditorBase::InsertTextImpl() should take |const EditorRawDOMPoint&| argument as input and |EditorRawDOMPoint*| as out argument instead of a set of container, child and offset of the child in the container as in/out argument r=m_kato https://hg.mozilla.org/integration/autoland/rev/799b7dee5ebf part 3: WSRunObject::InsertText() should take |const EditorRawDOMPoint&| as input argument and |EditorRawDOMPoint*| as out argument instead of a set of container, child and offset of the child in the container as in/out argument r=m_kato

https://hg.mozilla.org/mozilla-central/rev/e3d5220206fc https://hg.mozilla.org/mozilla-central/rev/c6844ea5e019 https://hg.mozilla.org/mozilla-central/rev/799b7dee5ebf