nsPrefBranch.cpp generates two compiler warnings on the "brad" tinderbox when building. One for an unused variable, and one for a "this variable might be used uninitialized". Every now and then I notice these and they annoy me.

This patch cleans up the aforementioned warnings, as well as others associated to alecf and ltabb caused by leftover cruft from previous cleanup. alecf, jag, could you please r/sr these changes?

Comment on attachment 81902 [details] [diff] [review] Cleanup patch sr=alecf

Comment on attachment 81902 [details] [diff] [review] Cleanup patch r=jag

Fix checked in.

This fixed seems to have introduced one new warning. Currently (http://tinderbox.mozilla.org/SeaMonkey/warn1020293880.9655.html) Tbox shows 1 warning on brad in libpref: modules/libpref/src/prefapi.cpp:1120 `enum PLDHashOperator pref_addChild(PLDHashTable *, PLDHashEntryHdr *, unsigned int, void *)' defined but not used

Oh slap me with a wet noodle! I forgot to kill the callback associated with: PREF_CreateChildList(const char* parent_node, char **child_list) Geez Alec, why didn't you just delete all this stuff when you reworked prefapi.c ;)

Patch to remove the remainder of the PREF_CreateChildList support. alecf, jag, you want to rs some more dead code removal please?

Comment on attachment 82050 [details] [diff] [review] Additional cleanup patch sr=jag

Comment on attachment 82050 [details] [diff] [review] Additional cleanup patch r=blythe

Additional cleanup patch checked in.

The most recent brad warnings list (http://tinderbox.mozilla.org/SeaMonkey/warn1020373020.5900.html) does not show any libpref warnings. Marking VERIFIED FIXED.