Closed Bug 1415820 Opened 7 years ago Closed 7 years ago

1.13 - 1.62% build times (windows2012-32, windows2012-64) regression on push 2013c8dd182429accca0dbdc734b100ff38becd0 (Wed Nov 8 2017)

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: igoldan, Unassigned)

References

Details

(Keywords: regression)

We have detected a build metrics regression from push: https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=2013c8dd182429accca0dbdc734b100ff38becd0 As author of one of the patches included in that push, we need your help to address this regression. Regressions: 2% build times summary windows2012-64 opt static-analysis taskcluster-c4.4xlarge 2,654.69 -> 2,697.68 1% build times summary windows2012-32 opt static-analysis taskcluster-c4.4xlarge 2,528.89 -> 2,557.47 You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=10438 On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format. To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics
Component: Untriaged → Build Config
Product: Firefox → Core
:gps Were these build time regressions expected? Can we resolve them?
Flags: needinfo?(gps)
This is bug 1416010. The regression should be harmless.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(gps)
Resolution: --- → WORKSFORME
:gps Looks like we now have big build time regressions: == Change summary for alert #10438 (as of Thu, 09 Nov 2017 04:37:55 GMT) == Regressions: 11% build times summary linux64 opt artifact taskcluster-m4.4xlarge 124.99 -> 138.67 8% build times summary linux64 opt artifact taskcluster-m4.4xlarge 126.74 -> 137.25 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=10438
Flags: needinfo?(gps)
Large in terms of percentage. Small in terms of wall time. Nothing really cares about these lost 10-13 seconds. And the regression should go away once client.mk is removed. The build times regression alone isn't worth worrying about.
Flags: needinfo?(gps)
I see most of the regressions got fixed. I'm marking this as fixed: == Change summary for alert #10573 (as of Tue, 14 Nov 2017 22:09:05 GMT) == Improvements: 11% build times summary linux64 opt artifact taskcluster-m4.4xlarge 138.58 -> 123.16 3% build times summary windows2012-64 opt static-analysis taskcluster-c4.4xlarge2,658.79 -> 2,581.86 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=10573
Resolution: WORKSFORME → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.