+++ This bug was initially created as a clone of Bug #1333126 +++ The browser_pluginCrashCommentAndURL.js test is problematic for two reasons: first of all it unsets MOZ_CRASHREPORTER_NO_REPORT which causes it to leave minidumps in the main UAppData folder on the machine instead of in the temporary directory created by the test. It also generates a crash dump which is never removed and causes the browser mochitest harness to race against the crash manager, usually failing silently and hanging. In this bug I'd like to address all three issues: - Fix browser_pluginCrashCommentAndURL.js to cleanup after itself (and wait for crashes to be recorded) - Ensure that it doesn't mess with MOZ_CRASHREPORTER_NO_REPORT - Make the test harness report if it couldn't delete the crash dump files. This ways if future issues crop they'll be immediately obvious instead of completely obscure as they are now.

Quick update: I've got a patch almost ready and I had to drop the idea of restoring MOZ_CRASHREPORTER_NO_REPORT. The reason it's being used is not the one described by the comment in the code, it's because it allows the crash submission code to locate the crash dump files. Without it CrashSubmit.jsm doesn't know where to look for them.

Comment on attachment 8927545 [details] Bug 1416028 - Prevent browser_pluginCrashedCommentAndURL.js from leaking crash dump files; https://reviewboard.mozilla.org/r/198854/#review204172 Thanks!

Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d80bc4f0161 Prevent browser_pluginCrashedCommentAndURL.js from leaking crash dump files; r=mconley