Closed Bug 1416029 Opened 7 years ago Closed 7 years ago

Pass empty TRY_COMMIT_MESSAGE to mozharness on windows.

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla58

People

(Reporter: tomprince, Assigned: tomprince)

References

Details

Attachments

(1 file)

Bug 1416029: Pass empty TRY_COMMIT_MESSAGE to mozharness on windows.
(deleted), text/x-review-board-request
dustin
: review+
Details
Apparently the window's generic-worker uses batch files for running setting environment variables. In windows batch files, setting an environment variable to empty actually unsets.
Blocks: comm-taskcluster
Comment on attachment 8927062 [details] Bug 1416029: Pass empty TRY_COMMIT_MESSAGE to mozharness on windows. https://reviewboard.mozilla.org/r/198276/#review203764 Would something like `"no commit message"` help with debugging down the line?
Attachment #8927062 - Flags: review?(dustin) → review+
Comment on attachment 8927062 [details] Bug 1416029: Pass empty TRY_COMMIT_MESSAGE to mozharness on windows. https://reviewboard.mozilla.org/r/198276/#review203764 My initial concern was that mozharness might try to interpret that, but looking at https://dxr.mozilla.org/mozilla-central/rev/2535bad09d720e71a982f3f70dd6925f66ab8ec7/testing/mozharness/mozharness/mozilla/testing/try_tools.py#130-147 that won't happen unless "try:" is in the message.
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/7b9a2e017069 Pass empty TRY_COMMIT_MESSAGE to mozharness on windows. r=dustin
https://hg.mozilla.org/mozilla-central/rev/7b9a2e017069
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: TaskCluster → Firefox Build System
Assignee: nobody → mozilla
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: