Closed
Bug 1416070
Opened 7 years ago
Closed 7 years ago
time bomb in test_validators.js causes permafailures
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: aryx, Assigned: aryx)
References
Details
https://treeherder.mozilla.org/logviewer.html#?job_id=143486388&repo=autoland
TEST-UNEXPECTED-FAIL | devtools/client/shared/vendor/stringvalidator/tests/unit/test_validators.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | devtools/client/shared/vendor/stringvalidator/tests/unit/test_validators.js | test/< - [test/< : 28] validator.isBefore(Fri Nov 10 2017 00:00:00 GMT+0000 (UTC)) == false - false == true
test({
validator: 'isBefore',
valid: [
'2000-08-04',
new Date(0).toString(),
new Date(Date.now() - 86400000).toString(),
],
invalid: ['2100-07-02', new Date(2017, 10, 10).toString()],
});
This landed in bug 1371568.
Flags: needinfo?(mratcliffe)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/mozilla-central/rev/ed94dc665071
Snooze time bomb in test_validators.js for 80 years or until a devtools peer fixes it. r=me on a CLOSED TREE
Assignee | ||
Comment 2•7 years ago
|
||
Pushed a temporary fix to central, autoland and inbound. Ryan, feel free to uplift it to beta and release, it got added in 56: https://hg.mozilla.org/mozilla-central/rev/eb46683ba2f8
Flags: needinfo?(ryanvm)
Comment 3•7 years ago
|
||
uplift |
Landed in https://hg.mozilla.org/releases/mozilla-release/rev/74203b7f9e0403df654f154583948ac53e0c6da4
status-firefox57:
--- → fixed
Updated•7 years ago
|
Flags: needinfo?(ryanvm)
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Flags: needinfo?(mratcliffe)
I have just looked into this and I think 80 years is plenty of wriggle room.
I am happy with the current fix.
Comment 5•7 years ago
|
||
Closing this since this was fixed in https://hg.mozilla.org/mozilla-central/rev/ed94dc665071
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 6•7 years ago
|
||
Just re-assigning to the person who made the fix.
Assignee: mratcliffe → aryx.bugmail
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•