Jeff Muizelaar [:jrmuizel] Reporter
	Description • 7 years ago

It seems like we could do something much simpler when we're using blob images.

	Ethan Lin[:ethlin] Assignee
	Comment 1 • 7 years ago

Indeed, the RecomputeVisibilty has some region computations. For webrender, we should just call ComputeVisibility.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 3 • 7 years ago

Please don't regress bug 1403920. I had changed this to RecomputeVisibility specifically to avoid that problem.

	Ethan Lin[:ethlin] Assignee
	Comment 4 • 7 years ago

(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #3)
> Please don't regress bug 1403920. I had changed this to RecomputeVisibility
> specifically to avoid that problem.

Oh..I should think another way.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 6 • 7 years ago
mozreview-review

Comment on attachment 8927257 [details]
Bug 1416076 - We should set visible rect to display item before computing visibility.

https://reviewboard.mozilla.org/r/198566/#review204330

Matt is probably a better reviewer for this visibility stuff.

::: commit-message-f944b:1
(Diff revision 2)
> +Bug 1416076 - We should set visibile rect to display item before computing visibility. r=kats

s/visibile/visible/

	Matt Woodrow (:mattwoodrow)
	Comment 7 • 7 years ago
mozreview-review

Comment on attachment 8927257 [details]
Bug 1416076 - We should set visible rect to display item before computing visibility.

https://reviewboard.mozilla.org/r/198566/#review204626

	Ethan Lin[:ethlin] Assignee
	Comment 9 • 7 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05a626c515e50c0487b7013d05d3b94285fab7b7

	Pulsebot
	Comment 10 • 7 years ago

Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b468a6f584f8
We should set visible rect to display item before computing visibility. r=mattwoodrow

	Noemi Erli[:noemi_erli]
	Comment 11 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/b468a6f584f8