Closed
Bug 1416754
Opened 7 years ago
Closed 7 years ago
SVG animation broken in Nightly 58 and 59
Categories
(Core :: SVG, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox57 | --- | unaffected |
firefox58 | --- | fixed |
firefox59 | --- | fixed |
People
(Reporter: coastermcgee, Assigned: botond)
References
Details
(Keywords: regression)
Attachments
(3 files)
(deleted),
text/html
|
Details | |
(deleted),
text/x-review-board-request
|
longsonr
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
(deleted),
text/x-review-board-request
|
longsonr
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20171113100232
Steps to reproduce:
View the following in Firefox 56 and 57 and it works fine. The same example in Nightly 58 and now 59 has some kind of glitch with the SVG path. I've tried a fresh profile on both Windows 10 64 bit Nightly and on Mac OS High Sierra and both have the same issue. This looks like it's a css problem introduced sometime during a Nightly 58 update.
http://bl.ocks.org/brattonc/5e5ce9beee483220e2f6
Actual results:
Glitched out SVG path.
Expected results:
Gauges should look fluid.
Comment 1•7 years ago
|
||
I can confirm this using 20171113100232 (59 nightly) on Mac. Adding relevant keywords to get a regression range.
Status: UNCONFIRMED → NEW
Component: Untriaged → SVG
Ever confirmed: true
Keywords: regression,
regressionwindow-wanted
Product: Firefox → Core
Updated•7 years ago
|
status-firefox58:
--- → affected
status-firefox59:
--- → affected
Comment 2•7 years ago
|
||
I can reproduce the glitch on Windows10.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fa3be8644d73a8ef20333924c11b70c5bc034fdf&tochange=ce7f71c2f402beaebf1485323144830e8743fffa
Regressed by: Bug 1382534
@:botond, Your bunch of patch seems to cause the regression. Can you look into this?
Comment hidden (obsolete) |
Updated•7 years ago
|
Priority: -- → P2
Assignee | ||
Comment 6•7 years ago
|
||
The testcase is animating the transform of an element inside a clip-path. Rendering is incorrect for a given single frame of the animation, suggesting that the issue is related to the transform itself, and not an invalidation problem related to the transform changing.
Assignee | ||
Comment 7•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8928712 -
Attachment mime type: text/plain → text/html
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•7 years ago
|
||
The attached patch fixes the problem for me locally.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=689b6144aba5dc49539c00470457ead08a7c733e
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8928730 -
Flags: review?(longsonr)
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8929590 [details]
Bug 1416754 - Reftest.
https://reviewboard.mozilla.org/r/200860/#review206128
Attachment #8929590 -
Flags: review?(longsonr) → review+
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8928730 [details]
Bug 1416754 - Account for a clip-path's transform in nsSVGUtils::GetBBox().
https://reviewboard.mozilla.org/r/200000/#review206130
Attachment #8928730 -
Flags: review?(longsonr) → review+
Comment 13•7 years ago
|
||
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74f295778860
Account for a clip-path's transform in nsSVGUtils::GetBBox(). r=longsonr
https://hg.mozilla.org/integration/autoland/rev/9ac3ceb81b01
Reftest. r=longsonr
Comment 14•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/74f295778860
https://hg.mozilla.org/mozilla-central/rev/9ac3ceb81b01
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment 15•7 years ago
|
||
Please help to create uplift request for 58 beta. Thanks.
Flags: needinfo?(botond)
Assignee | ||
Comment 16•7 years ago
|
||
Comment on attachment 8928730 [details]
Bug 1416754 - Account for a clip-path's transform in nsSVGUtils::GetBBox().
Approval Request Comment
[Feature/Bug causing the regression]:
Bug 1382534
[User impact if declined]:
SVG images (could be static images or animations)
involving a clip-path with a transform are rendered
incorrectly.
[Is this code covered by automated tests?]:
Yes
[Has the fix been verified in Nightly?]:
Yes
[Needs manual test from QE? If yes, steps to reproduce]:
No
[List of other uplifts needed for the feature/fix]:
None
[Is the change risky?]:
No
[Why is the change risky/not risky?]:
It's a straightforward, one line change
[String changes made/needed]:
None
Flags: needinfo?(botond)
Attachment #8928730 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 17•7 years ago
|
||
Comment on attachment 8929590 [details]
Bug 1416754 - Reftest.
(See previous comment)
Attachment #8929590 -
Flags: approval-mozilla-beta?
Comment 18•7 years ago
|
||
Comment on attachment 8928730 [details]
Bug 1416754 - Account for a clip-path's transform in nsSVGUtils::GetBBox().
Fix a SVG animation regression. Beta58+.
Attachment #8928730 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•7 years ago
|
Attachment #8929590 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 19•7 years ago
|
||
bugherder uplift |
Updated•7 years ago
|
status-firefox57:
--- → unaffected
status-firefox-esr52:
--- → unaffected
You need to log in
before you can comment on or make changes to this bug.
Description
•