Bug 1342762 addressed pipeline leaks for video and canvas. But there is still a leak of Tabs. It should be easy to address.

Comment on attachment 8928384 [details] [diff] [review] patch - Fix leaking pipelines of Tabs Review of attachment 8928384 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/wr/WebRenderBridgeParent.cpp @@ +1374,5 @@ > } > mAsyncCompositables.Clear(); > > mAsyncImageManager->RemovePipeline(mPipelineId, wr::NewEpoch(wrEpoch)); > + mApi->RemovePipeline(mPipelineId); nit: it would probably be safer to also clear mPipelineId (like set it to some recognizable and know to be wrong value like 0), just to make it apparent that something's wrong if we accidentally use it again after that.

(In reply to Nicolas Silva [:nical] from comment #3) > Comment on attachment 8928384 [details] [diff] [review] > patch - Fix leaking pipelines of Tabs > > ::: gfx/layers/wr/WebRenderBridgeParent.cpp > @@ +1374,5 @@ > > } > > mAsyncCompositables.Clear(); > > > > mAsyncImageManager->RemovePipeline(mPipelineId, wr::NewEpoch(wrEpoch)); > > + mApi->RemovePipeline(mPipelineId); > > nit: it would probably be safer to also clear mPipelineId (like set it to > some recognizable and know to be wrong value like 0), just to make it > apparent that something's wrong if we accidentally use it again after that. mPipelineId is also used as LayersId. It seems better not to change it in this bug.

Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/393eddd4e496 Fix leaking pipelines of Tabs r=nical