Closed
Bug 1417356
Opened 7 years ago
Closed 7 years ago
stylo: Some web extension xpcshell tests on Android are failure with stylo
Categories
(Core Graveyard :: Widget: Android, defect)
Core Graveyard
Widget: Android
Tracking
(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)
RESOLVED
FIXED
mozilla59
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
https://treeherder.mozilla.org/logviewer.html#?job_id=144885429&repo=try&lineNumber=1717 xpcshell doesn't have Java thread...
|
Assignee | |
Comment 1•7 years ago
|
||
maybe, this is a regression by bug 1403690
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → m_kato
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8928805 [details] Bug 1417356 - xpcshell doesn't have Java thread. https://reviewboard.mozilla.org/r/200080/#review205526 ::: widget/android/nsLookAndFeel.cpp:518 (Diff revision 1) > - mShowPassword = java::GeckoAppShell::GetShowPasswordSetting(); > + mShowPassword = jni::IsAvailable() ? > + java::GeckoAppShell::GetShowPasswordSetting() : > + false; // xpcshell case How about this? mShowPassword = jni::IsAvailable() && java::GeckoAppShell::GetShowPasswordSetting();
Attachment #8928805 -
Flags: review?(nchen) → review+
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/mozilla-inbound/rev/144f04d80cf1 xpcshell doesn't have Java thread. r=jchen
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/144f04d80cf1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
|
||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
status-firefox58:
--- → wontfix
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•