Closed
Bug 1417368
Opened 7 years ago
Closed 7 years ago
Fixing launchpad `response is undefined` error & Toolbox.shouldComponentUpdate warning
Categories
(DevTools :: Netmonitor, defect, P2)
DevTools
Netmonitor
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Firefox 59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: rickychien, Assigned: rickychien)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 file)
|
Bug 1417368 - Fixing launchpad `response is undefined` error & Toolbox.shouldComponentUpdate warning
(deleted),
text/x-review-board-request
|
Honza
:
review+
|
Details |
Launchpad is broken by regression from bug 1404917. It throws `TypeError: response is undefined` on console. On the other hand, there is an Toolbox.shouldComponentUpdate warning on console as well.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → rchien
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8928463 [details] Bug 1417368 - Fixing launchpad `response is undefined` error & Toolbox.shouldComponentUpdate warning https://reviewboard.mozilla.org/r/199714/#review204828 Looks reasonable to me R+ assumin try is green Thanks Ricky for fixing this! Honza
Attachment #8928463 -
Flags: review?(odvarko) → review+
Pushed by rchien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/432b91c9ad95 Fixing launchpad `response is undefined` error & Toolbox.shouldComponentUpdate warning r=Honza
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/432b91c9ad95
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•