Closed
Bug 1417677
Opened 7 years ago
Closed 7 years ago
remove security.use_sqldb preference (require sqlite-backed certificate/key DBs)
Categories
(Core :: Security: PSM, enhancement, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: keeler, Assigned: keeler)
References
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
We have the preference "security.use_sqldb" to control whether or not the platform uses the sqlite-backed certificate/key databases in NSS. To move forward with our grand plan of not shutting down NSS, we'll need to ensure that the platform is using the sqlite version and not the old dbm implementation. So, we need to remove the preference.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8929099 [details]
bug 1417677 - remove "security.use_sqldb" and always use the sqlite-backed NSS DBs
https://reviewboard.mozilla.org/r/200394/#review205588
Looks good!
Attachment #8929099 -
Flags: review?(jjones) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Thanks! Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4464b1fd61d8ef7a78c4db5f87bb0165c992942c
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/614a09e35ff0
remove "security.use_sqldb" and always use the sqlite-backed NSS DBs r=jcj
Comment 5•7 years ago
|
||
Backed out for failing security/manager/ssl/tests/unit/test_broken_fips.js on a CLOSED TREE
Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=614a09e35ff019a5003bc7c7c9265e715e934684&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-searchStr=xpcshell%20os%20x
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=145455802&repo=autoland&lineNumber=7985
Back out: https://hg.mozilla.org/integration/autoland/rev/2de93d419be11b52a23b233ef5f55251c85fad86
Flags: needinfo?(dkeeler)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•7 years ago
|
||
Heh - well, it's a good thing we have tests.
Flags: needinfo?(dkeeler)
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8929099 [details]
bug 1417677 - remove "security.use_sqldb" and always use the sqlite-backed NSS DBs
https://reviewboard.mozilla.org/r/200394/#review206074
r+ on the interdiff
Assignee | ||
Comment 9•7 years ago
|
||
Thanks! Now with actual OS X test coverage: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e86415d81622
Comment 10•7 years ago
|
||
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aea6154d26f3
remove "security.use_sqldb" and always use the sqlite-backed NSS DBs r=jcj
Comment 11•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•