Closed
Bug 1417874
Opened 7 years ago
Closed 7 years ago
Split clipboard implementation to shared and backend specific parts
Categories
(Core :: Widget: Gtk, enhancement)
Core
Widget: Gtk
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
Details
Attachments
(1 file)
We need to divide clipboard code to universal and backend specific parts to provide Gtk+/X11 and Wayland clipboard backends.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8928985 [details]
Bug 1417874 - Split clipboard implementation to shared (nsClipboard) and backend specific (nsClipboardX11) parts,
https://reviewboard.mozilla.org/r/200318/#review205898
::: widget/gtk/nsClipboardX11.cpp:233
(Diff revision 1)
> +nsRetrievalContextX11::WaitForContents(GtkClipboard *clipboard, const char *aMimeType)
> +{
> + mState = INITIAL;
> + NS_ASSERTION(!mData, "Leaking clipboard content!");
> +
> + gtk_clipboard_request_contents(clipboard,
It has to be updated as per https://bugzilla.mozilla.org/show_bug.cgi?id=1282015#c12
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 4•7 years ago
|
||
Seems to fail at some tests:
[task 2017-11-27T10:05:03.792Z] 10:05:03 INFO - TEST-UNEXPECTED-FAIL | widget/tests/test_bug444800.xul | uncaught exception - NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITransferable.getAnyTransferData] at runImageClipboardTests@chrome://mochitests/content/chrome/widget/tests/test_bug444800.xul:64:3
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8928985 -
Flags: review?(jhorak)
| Comment hidden (mozreview-request) |
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8928985 [details]
Bug 1417874 - Split clipboard implementation to shared (nsClipboard) and backend specific (nsClipboardX11) parts,
https://reviewboard.mozilla.org/r/200318/#review211354
::: widget/gtk/nsClipboard.cpp:14
(Diff revision 3)
>
> #include "nsArrayUtils.h"
> #include "nsClipboard.h"
> +#include "nsClipboardX11.h"
> +#if defined(MOZ_WAYLAND)
> +#include "nsClipboardWayland.h"
This seems to be not part of this change. Please move it to the patch which implements clipboard in wayland.
::: widget/gtk/nsClipboard.cpp:60
(Diff revision 3)
> int32_t &outUnicodeLen);
>
> static void
> GetHTMLCharset (guchar * data, int32_t dataLength, nsCString& str);
>
> +GdkAtom
Please add 'static' for completeness.
::: widget/gtk/nsClipboard.cpp:70
(Diff revision 3)
> -// gtk_clipboard_wait_for_text, which don't run the event loop while
> -// waiting for the data. This prevents a lot of problems related to
> +const int
> +nsRetrievalContext::kClipboardTimeout = 500000;
nit: This can stay in one line.
::: widget/gtk/nsClipboard.cpp
(Diff revision 3)
> +
> nsresult
> nsClipboard::Store(void)
> {
> - // Ask the clipboard manager to store the current clipboard content
> - if (mGlobalTransferable) {
Please double check if removal of this is actually desired.
::: widget/gtk/nsClipboard.cpp:378
(Diff revision 3)
> - return NS_ERROR_NULL_POINTER;
> + return NS_ERROR_NULL_POINTER;
>
> - *_retval = false;
> + *_retval = false;
>
> - GtkSelectionData *selection_data =
> - GetTargets(GetSelectionAtom(aWhichClipboard));
> + int targetNum;
> + GdkAtom* targets = mContext->GetTargets(aWhichClipboard, &targetNum);
nit: please use plural: targetNums, to be more clear that it is a total count of targets.
::: widget/gtk/nsClipboard.cpp:509
(Diff revision 3)
> return;
>
> gtk_selection_data_set_text (aSelectionData, utf8string,
> strlen(utf8string));
>
> - free(utf8string);
> + g_free(utf8string);
Hm, why this change? It does not seems that utf8string is a gchar.
::: widget/gtk/nsClipboardX11.h:46
(Diff revision 3)
> + State mState;
> + void* mData;
> + int mRequestStamp;
> +};
> +
> +class nsRequestStampShell
nit: please consider some better name, like nsClipboardRequestRecord or nsClipboardRequestIdentifier
::: widget/gtk/nsClipboardX11.h:61
(Diff revision 3)
> + mContext->Complete(aData, mRequestStamp);
> + }
> +
> +private:
> + nsRetrievalContextX11 *mContext;
> + int mRequestStamp;
Better mRequestNumber
::: widget/gtk/nsClipboardX11.cpp:209
(Diff revision 3)
> +}
> +
> +// Call this when data has been retrieved.
> +void nsRetrievalContextX11::Complete(GtkSelectionData* aData, int aRequestStamp)
> +{
> + if (mRequestStamp != aRequestStamp)
Adding some NS_Warning why the early return happened could be useful there for debugging purposes.
::: widget/gtk/nsClipboardX11.cpp:239
(Diff revision 3)
> + const char *aMimeType)
> +{
> + mState = INITIAL;
> + NS_ASSERTION(!mData, "Leaking clipboard content!");
> +
> + mRequestStamp++;
Better like mRequestNumber
Attachment #8928985 -
Flags: review?(jhorak) → review-
|
|
Assignee | |
Comment 7•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8928985 [details]
Bug 1417874 - Split clipboard implementation to shared (nsClipboard) and backend specific (nsClipboardX11) parts,
https://reviewboard.mozilla.org/r/200318/#review211354
> Please double check if removal of this is actually desired.
Thanks, I missed the mGlobalTransferable check.
> Hm, why this change? It does not seems that utf8string is a gchar.
Reverted, Thanks.
| Comment hidden (mozreview-request) |
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8928985 [details]
Bug 1417874 - Split clipboard implementation to shared (nsClipboard) and backend specific (nsClipboardX11) parts,
https://reviewboard.mozilla.org/r/200318/#review211824
Attachment #8928985 -
Flags: review?(jhorak) → review+
|
||
Comment 10•7 years ago
|
||
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/b35e86822732
Split clipboard implementation to shared (nsClipboard) and backend specific (nsClipboardX11) parts, r=jhorak
|
|
||
Comment 11•7 years ago
|
||
Backout by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02016450850a
Backed out 1 changesets for causing frequent Linux chrome failure in toolkit/content/tests/chrome/test_chromemargin.xul r=backout on a CLOSED TREE
|
||
Comment 12•7 years ago
|
||
Backed out bug 1417874 and bug 1423869 for causing frequent Linux chrome failure in toolkit/content/tests/chrome/test_chromemargin.xul (please check which patch is responsible and reland the other one):
bug 1417874
https://hg.mozilla.org/integration/autoland/rev/02016450850a73d021b083b545b5cac17608f366
bug 1423869
https://hg.mozilla.org/integration/autoland/rev/762445af77cbbc0f561d0ffcfc381203c6de90bd
Push range with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=d71f9e83d6ef7affa3b707cd4a2be0f21ebf8378&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-searchStr=linux%20M%28c3%29&tochange=762445af77cbbc0f561d0ffcfc381203c6de90bd
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=150521887&repo=autoland
[task 2017-12-07T15:33:42.325Z] 15:33:42 INFO - TEST-START | toolkit/content/tests/chrome/test_chromemargin.xul
[task 2017-12-07T15:33:42.349Z] 15:33:42 INFO - GECKO(4779) | ++DOMWINDOW == 84 (0xd7a6b000) [pid = 4779] [serial = 139] [outer = 0xcd7f0040]
[task 2017-12-07T15:33:42.468Z] 15:33:42 INFO - GECKO(4779) | ++DOCSHELL 0xd7a67800 == 10 [pid = 4779] [id = {5baff83b-c496-4434-84ba-2faf399144ec}]
[task 2017-12-07T15:33:42.468Z] 15:33:42 INFO - GECKO(4779) | ++DOMWINDOW == 85 (0xcd609280) [pid = 4779] [serial = 140] [outer = (nil)]
[task 2017-12-07T15:33:42.468Z] 15:33:42 INFO - GECKO(4779) | ++DOMWINDOW == 86 (0xd7a68800) [pid = 4779] [serial = 141] [outer = 0xcd609280]
[task 2017-12-07T15:33:42.691Z] 15:33:42 INFO - GECKO(4779) | Hit MOZ_CRASH(X_CreateGC: BadDrawable (invalid Pixmap or Window parameter); 5 requests ago; id=0x0
[task 2017-12-07T15:33:42.693Z] 15:33:42 INFO - GECKO(4779) | Re-running with MOZ_X_SYNC=1 in the environment may give a more helpful backtrace.) at /builds/worker/workspace/build/src/toolkit/xre/nsX11ErrorHandler.cpp:145
[task 2017-12-07T15:33:42.693Z] 15:33:42 INFO - GECKO(4779) | ExceptionHandler::GenerateDump cloned child 4974
[task 2017-12-07T15:33:42.694Z] 15:33:42 INFO - GECKO(4779) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2017-12-07T15:33:42.695Z] 15:33:42 INFO - GECKO(4779) | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2017-12-07T15:33:42.943Z] 15:33:42 INFO - GECKO(4779) | Hit MOZ_CRASH(Aborting on channel error.) at /builds/worker/workspace/build/src/ipc/glue/MessageChannel.cpp:2534
[task 2017-12-07T15:33:42.945Z] 15:33:42 INFO - GECKO(4779) | #01: mozilla::ipc::MessageChannel::OnChannelErrorFromLink [ipc/glue/MessageChannel.cpp:2534]
[task 2017-12-07T15:33:42.946Z] 15:33:42 INFO -
[task 2017-12-07T15:33:42.948Z] 15:33:42 INFO - GECKO(4779) | #02: mozilla::ipc::ProcessLink::OnChannelError [ipc/glue/MessageLink.cpp:389]
[task 2017-12-07T15:33:42.950Z] 15:33:42 INFO -
[task 2017-12-07T15:33:42.952Z] 15:33:42 INFO - GECKO(4779) | #03: IPC::Channel::ChannelImpl::OnFileCanReadWithoutBlocking [ipc/chromium/src/chrome/common/ipc_channel_posix.cc:802]
[task 2017-12-07T15:33:42.955Z] 15:33:42 INFO -
[task 2017-12-07T15:33:42.957Z] 15:33:42 INFO - GECKO(4779) | #04: event_process_active_single_queue [ipc/chromium/src/third_party/libevent/event.c:1648]
[task 2017-12-07T15:33:42.961Z] 15:33:42 INFO -
[task 2017-12-07T15:33:42.967Z] 15:33:42 INFO - GECKO(4779) | #05: event_base_loop [ipc/chromium/src/third_party/libevent/event.c:1741]
[task 2017-12-07T15:33:42.970Z] 15:33:42 INFO -
[task 2017-12-07T15:33:42.973Z] 15:33:42 INFO - GECKO(4779) | #06: base::MessagePumpLibevent::Run [ipc/chromium/src/base/message_pump_libevent.cc:381]
[task 2017-12-07T15:33:42.975Z] 15:33:42 INFO -
[task 2017-12-07T15:33:42.977Z] 15:33:42 INFO - GECKO(4779) | #07: MessageLoop::RunInternal [ipc/chromium/src/base/message_loop.cc:327]
[task 2017-12-07T15:33:42.980Z] 15:33:42 INFO -
[task 2017-12-07T15:33:42.983Z] 15:33:42 INFO - GECKO(4779) | #08: MessageLoop::Run [ipc/chromium/src/base/message_loop.cc:298]
[task 2017-12-07T15:33:42.985Z] 15:33:42 INFO -
[task 2017-12-07T15:33:42.988Z] 15:33:42 INFO - GECKO(4779) | #09: base::Thread::ThreadMain [ipc/chromium/src/base/thread.cc:184]
[task 2017-12-07T15:33:42.990Z] 15:33:42 INFO -
[task 2017-12-07T15:33:42.997Z] 15:33:42 INFO - GECKO(4779) | #10: ThreadFunc [ipc/chromium/src/base/platform_thread_posix.cc:40]
[task 2017-12-07T15:33:42.999Z] 15:33:42 INFO -
[task 2017-12-07T15:33:43.001Z] 15:33:43 INFO - GECKO(4779) | #11: libpthread.so.0 + 0x6295
[task 2017-12-07T15:33:43.002Z] 15:33:43 INFO -
[task 2017-12-07T15:33:43.105Z] 15:33:43 INFO - TEST-INFO | Main app process: exit 11
[task 2017-12-07T15:33:43.108Z] 15:33:43 INFO - Buffered messages logged at 15:33:42
[task 2017-12-07T15:33:43.110Z] 15:33:43 INFO - must wait for load
[task 2017-12-07T15:33:43.112Z] 15:33:43 INFO - must wait for focus
[task 2017-12-07T15:33:43.113Z] 15:33:43 INFO - TEST-PASS | toolkit/content/tests/chrome/test_chromemargin.xul | couldn't set/get chromemargin?
[task 2017-12-07T15:33:43.115Z] 15:33:43 INFO - Buffered messages finished
[task 2017-12-07T15:33:43.117Z] 15:33:43 ERROR - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_chromemargin.xul | application terminated with exit code 11
[task 2017-12-07T15:33:43.118Z] 15:33:43 INFO - runtests.py | Application ran for: 0:01:32.068653
[task 2017-12-07T15:33:43.120Z] 15:33:43 INFO - zombiecheck | Reading PID log: /tmp/tmpHwoKzUpidlog
[task 2017-12-07T15:33:43.121Z] 15:33:43 INFO - ==> process 4779 launched child process 4802
[task 2017-12-07T15:33:43.123Z] 15:33:43 INFO - ==> process 4779 launched child process 4863
[task 2017-12-07T15:33:43.124Z] 15:33:43 INFO - ==> process 4779 launched child process 4893
[task 2017-12-07T15:33:43.125Z] 15:33:43 INFO - ==> process 4779 launched child process 4920
[task 2017-12-07T15:33:43.127Z] 15:33:43 INFO - ==> process 4779 launched child process 4948
[task 2017-12-07T15:33:43.128Z] 15:33:43 INFO - zombiecheck | Checking for orphan process with PID: 4920
[task 2017-12-07T15:33:43.130Z] 15:33:43 INFO - zombiecheck | Checking for orphan process with PID: 4802
[task 2017-12-07T15:33:43.131Z] 15:33:43 INFO - zombiecheck | Checking for orphan process with PID: 4948
[task 2017-12-07T15:33:43.133Z] 15:33:43 INFO - zombiecheck | Checking for orphan process with PID: 4893
[task 2017-12-07T15:33:43.134Z] 15:33:43 INFO - zombiecheck | Checking for orphan process with PID: 4863
[task 2017-12-07T15:33:43.136Z] 15:33:43 INFO - mozcrash Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/tmp8iQEA7.mozrunner/minidumps/6c250d71-caa7-922a-f8e6-487fcf1e6b2c.dmp /builds/worker/workspace/build/symbols
[task 2017-12-07T15:33:51.573Z] 15:33:51 INFO - mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/6c250d71-caa7-922a-f8e6-487fcf1e6b2c.dmp
[task 2017-12-07T15:33:51.573Z] 15:33:51 INFO - mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/6c250d71-caa7-922a-f8e6-487fcf1e6b2c.extra
[task 2017-12-07T15:33:51.653Z] 15:33:51 INFO - PROCESS-CRASH | toolkit/content/tests/chrome/test_chromemargin.xul | application crashed [@ MOZ_CrashOOL]
[task 2017-12-07T15:33:51.654Z] 15:33:51 INFO - Crash dump filename: /tmp/tmp8iQEA7.mozrunner/minidumps/6c250d71-caa7-922a-f8e6-487fcf1e6b2c.dmp
[task 2017-12-07T15:33:51.654Z] 15:33:51 INFO - Operating system: Linux
[task 2017-12-07T15:33:51.655Z] 15:33:51 INFO - 0.0.0 Linux 3.13.0-112-generic #159-Ubuntu SMP Fri Mar 3 15:26:07 UTC 2017 x86_64
[task 2017-12-07T15:33:51.655Z] 15:33:51 INFO - CPU: x86
[task 2017-12-07T15:33:51.656Z] 15:33:51 INFO - GenuineIntel family 6 model 62 stepping 4
[task 2017-12-07T15:33:51.656Z] 15:33:51 INFO - 2 CPUs
[task 2017-12-07T15:33:51.657Z] 15:33:51 INFO -
[task 2017-12-07T15:33:51.657Z] 15:33:51 INFO - GPU: UNKNOWN
[task 2017-12-07T15:33:51.657Z] 15:33:51 INFO -
[task 2017-12-07T15:33:51.658Z] 15:33:51 INFO - Crash reason: SIGSEGV
[task 2017-12-07T15:33:51.658Z] 15:33:51 INFO - Crash address: 0x0
[task 2017-12-07T15:33:51.659Z] 15:33:51 INFO - Process uptime: not available
[task 2017-12-07T15:33:51.659Z] 15:33:51 INFO -
[task 2017-12-07T15:33:51.660Z] 15:33:51 INFO - Thread 0 (crashed)
[task 2017-12-07T15:33:51.660Z] 15:33:51 INFO - 0 firefox!MOZ_CrashOOL [Assertions.cpp:cd64829da06b : 33 + 0x0]
[task 2017-12-07T15:33:51.661Z] 15:33:51 INFO - eip = 0x0804d25f esp = 0xffe69aa0 ebp = 0xffe69aa8 ebx = 0xcd5bac0c
[task 2017-12-07T15:33:51.661Z] 15:33:51 INFO - esi = 0x08086000 edi = 0xf64efa30 eax = 0x08086980 ecx = 0xf7571864
[task 2017-12-07T15:33:51.662Z] 15:33:51 INFO - edx = 0x00000000 efl = 0x00010286
[task 2017-12-07T15:33:51.662Z] 15:33:51 INFO - Found by: given as instruction pointer in context
[task 2017-12-07T15:33:51.663Z] 15:33:51 INFO - 1 libxul.so!X11Error [nsX11ErrorHandler.cpp:cd64829da06b : 145 + 0x18]
[task 2017-12-07T15:33:51.663Z] 15:33:51 INFO - eip = 0xf253a16d esp = 0xffe69ab0 ebp = 0xffe6a3a8 ebx = 0xf552b000
[task 2017-12-07T15:33:51.664Z] 15:33:51 INFO - esi = 0xffe69b40 edi = 0xf64efa30
[task 2017-12-07T15:33:51.664Z] 15:33:51 INFO - Found by: call frame info
[task 2017-12-07T15:33:51.665Z] 15:33:51 INFO - 2 libxul.so!GdkErrorHandler [nsGDKErrorHandler.cpp:cd64829da06b : 84 + 0x5]
[task 2017-12-07T15:33:51.665Z] 15:33:51 INFO - eip = 0xf253a416 esp = 0xffe6a3b0 ebp = 0xffe6a458 ebx = 0xf552b000
[task 2017-12-07T15:33:51.666Z] 15:33:51 INFO - esi = 0xf55498cc edi = 0xffe6a42c
[task 2017-12-07T15:33:51.666Z] 15:33:51 INFO - Found by: call frame info
[task 2017-12-07T15:33:51.666Z] 15:33:51 INFO - 3 libglib-2.0.so.0.4800.2 + 0x4d63b
[task 2017-12-07T15:33:51.667Z] 15:33:51 INFO - eip = 0xf5e5663b esp = 0xffe6a460 ebp = 0x00000004 ebx = 0xf5f31000
[task 2017-12-07T15:33:51.667Z] 15:33:51 INFO - esi = 0x00000002 edi = 0x00000000
[task 2017-12-07T15:33:51.668Z] 15:33:51 INFO - Found by: call frame info
[task 2017-12-07T15:33:51.668Z] 15:33:51 INFO - 4 libgdk-3.so.0.1800.9 + 0x86a8e
[task 2017-12-07T15:33:51.669Z] 15:33:51 INFO - eip = 0xf668ea8e esp = 0xffe6a464 ebp = 0x00000004
[task 2017-12-07T15:33:51.669Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.670Z] 15:33:51 INFO - 5 libglib-2.0.so.0.4800.2 + 0x128a84
[task 2017-12-07T15:33:51.671Z] 15:33:51 INFO - eip = 0xf5f31a84 esp = 0xffe6a474 ebp = 0x00000004
[task 2017-12-07T15:33:51.671Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.672Z] 15:33:51 INFO - 6 firefox!AutoLock<Mutex>::~AutoLock [Mutex.h:cd64829da06b : 79 + 0xb]
[task 2017-12-07T15:33:51.673Z] 15:33:51 INFO - eip = 0x0804f644 esp = 0xffe6a480 ebp = 0xffe6a498
[task 2017-12-07T15:33:51.673Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.674Z] 15:33:51 INFO - 7 0x6
[task 2017-12-07T15:33:51.675Z] 15:33:51 INFO - eip = 0x00000006 esp = 0xffe6a4a0 ebp = 0x00000006 ebx = 0xf668ea8e
[task 2017-12-07T15:33:51.675Z] 15:33:51 INFO - esi = 0xf5f31aa0
[task 2017-12-07T15:33:51.676Z] 15:33:51 INFO - Found by: call frame info
[task 2017-12-07T15:33:51.677Z] 15:33:51 INFO - 8 libxul.so!X11Error [nsX11ErrorHandler.cpp:cd64829da06b : 45 + 0x9]
[task 2017-12-07T15:33:51.677Z] 15:33:51 INFO - eip = 0xf253a176 esp = 0xffe6a4a4 ebp = 0x00000006
[task 2017-12-07T15:33:51.678Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.679Z] 15:33:51 INFO - 9 libgdk-3.so.0.1800.9 + 0x86a8e
[task 2017-12-07T15:33:51.679Z] 15:33:51 INFO - eip = 0xf668ea8e esp = 0xffe6a4ac ebp = 0x00000006
[task 2017-12-07T15:33:51.680Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.681Z] 15:33:51 INFO - 10 libglib-2.0.so.0.4800.2 + 0x12845c
[task 2017-12-07T15:33:51.681Z] 15:33:51 INFO - eip = 0xf5f3145c esp = 0xffe6a4b0 ebp = 0x00000006
[task 2017-12-07T15:33:51.682Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.682Z] 15:33:51 INFO - 11 libgdk-3.so.0.1800.9 + 0xeaba0
[task 2017-12-07T15:33:51.683Z] 15:33:51 INFO - eip = 0xf66f2ba0 esp = 0xffe6a4b4 ebp = 0x00000006
[task 2017-12-07T15:33:51.683Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.684Z] 15:33:51 INFO - 12 ld-2.23.so + 0xe8c2
[task 2017-12-07T15:33:51.685Z] 15:33:51 INFO - eip = 0xf77bc8c2 esp = 0xffe6a4b8 ebp = 0x00000006
[task 2017-12-07T15:33:51.685Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.685Z] 15:33:51 INFO - 13 libglib-2.0.so.0.4800.2 + 0x65865
[task 2017-12-07T15:33:51.686Z] 15:33:51 INFO - eip = 0xf5e6e865 esp = 0xffe6a4d0 ebp = 0x00000006
[task 2017-12-07T15:33:51.686Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.687Z] 15:33:51 INFO - 14 libgdk-3.so.0.1800.9 + 0xa2708
[task 2017-12-07T15:33:51.687Z] 15:33:51 INFO - eip = 0xf66aa708 esp = 0xffe6a4d8 ebp = 0xffe6a4e8
[task 2017-12-07T15:33:51.688Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.688Z] 15:33:51 INFO - 15 0x759abd00
[task 2017-12-07T15:33:51.688Z] 15:33:51 INFO - eip = 0x759abd00 esp = 0xffe6a4f0 ebp = 0xdbbae400
[task 2017-12-07T15:33:51.689Z] 15:33:51 INFO - Found by: previous frame's frame pointer
[task 2017-12-07T15:33:51.689Z] 15:33:51 INFO - 16 libglib-2.0.so.0.4800.2 + 0x40a8
[task 2017-12-07T15:33:51.689Z] 15:33:51 INFO - eip = 0xf5e0d0a8 esp = 0xffe6a4f8 ebp = 0xffe6a50c
[task 2017-12-07T15:33:51.690Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.690Z] 15:33:51 INFO - 17 libgdk-3.so.0.1800.9 + 0x86a8e
[task 2017-12-07T15:33:51.691Z] 15:33:51 INFO - eip = 0xf668ea8e esp = 0xffe6a514 ebp = 0xf5e56815
[task 2017-12-07T15:33:51.691Z] 15:33:51 INFO - Found by: previous frame's frame pointer
[task 2017-12-07T15:33:51.691Z] 15:33:51 INFO - 18 libgdk-3.so.0.1800.9 + 0xa3313
[task 2017-12-07T15:33:51.692Z] 15:33:51 INFO - eip = 0xf66ab313 esp = 0xffe6a51c ebp = 0xf5e56815
[task 2017-12-07T15:33:51.692Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.693Z] 15:33:51 INFO - 19 libgdk-3.so.0.1800.9 + 0x86a8e
[task 2017-12-07T15:33:51.693Z] 15:33:51 INFO - eip = 0xf668ea8e esp = 0xffe6a524 ebp = 0xffe6a53c
[task 2017-12-07T15:33:51.693Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.694Z] 15:33:51 INFO - 20 0xf7147100
[task 2017-12-07T15:33:51.694Z] 15:33:51 INFO - eip = 0xf7147100 esp = 0xffe6a544 ebp = 0xdbbae400
[task 2017-12-07T15:33:51.695Z] 15:33:51 INFO - Found by: previous frame's frame pointer
[task 2017-12-07T15:33:51.695Z] 15:33:51 INFO - 21 libgdk-3.so.0.1800.9 + 0xa2121
[task 2017-12-07T15:33:51.695Z] 15:33:51 INFO - eip = 0xf66aa121 esp = 0xffe6a550 ebp = 0xdbbae400
[task 2017-12-07T15:33:51.696Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.696Z] 15:33:51 INFO - 22 libxcb.so.1.1.0 + 0x25000
[task 2017-12-07T15:33:51.697Z] 15:33:51 INFO - eip = 0xf5c20000 esp = 0xffe6a558 ebp = 0xdbbae400
[task 2017-12-07T15:33:51.697Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.697Z] 15:33:51 INFO - 23 firefox!arena_t::DallocSmall [mozjemalloc.cpp:cd64829da06b : 3396 + 0xa]
[task 2017-12-07T15:33:51.698Z] 15:33:51 INFO - eip = 0x08055c34 esp = 0xffe6a55c ebp = 0xdbbae400
[task 2017-12-07T15:33:51.698Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.699Z] 15:33:51 INFO - 24 libmozsqlite3.so!detachFunc [sqlite3.c:cd64829da06b : 100122 + 0xc]
[task 2017-12-07T15:33:51.699Z] 15:33:51 INFO - eip = 0xf7000000 esp = 0xffe6a59c ebp = 0xdbbae400
[task 2017-12-07T15:33:51.699Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.700Z] 15:33:51 INFO - 25 libgdk-3.so.0.1800.9 + 0x4b429
[task 2017-12-07T15:33:51.701Z] 15:33:51 INFO - eip = 0xf6653429 esp = 0xffe6a5ac ebp = 0xdbbae400
[task 2017-12-07T15:33:51.702Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.702Z] 15:33:51 INFO - 26 libgdk-3.so.0.1800.9 + 0xea000
[task 2017-12-07T15:33:51.703Z] 15:33:51 INFO - eip = 0xf66f2000 esp = 0xffe6a5b0 ebp = 0xdbbae400
[task 2017-12-07T15:33:51.704Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.705Z] 15:33:51 INFO - 27 libgdk-3.so.0.1800.9 + 0x56aa4
[task 2017-12-07T15:33:51.706Z] 15:33:51 INFO - eip = 0xf665eaa4 esp = 0xffe6a5c0 ebp = 0xdbbae400
[task 2017-12-07T15:33:51.707Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.707Z] 15:33:51 INFO - 28 libgdk-3.so.0.1800.9 + 0x56a6a
[task 2017-12-07T15:33:51.708Z] 15:33:51 INFO - eip = 0xf665ea6a esp = 0xffe6a5d0 ebp = 0xdbbae400
[task 2017-12-07T15:33:51.709Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.710Z] 15:33:51 INFO - 29 libgdk-3.so.0.1800.9 + 0x56a09
[task 2017-12-07T15:33:51.711Z] 15:33:51 INFO - eip = 0xf665ea09 esp = 0xffe6a5dc ebp = 0xdbbae400
[task 2017-12-07T15:33:51.712Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.712Z] 15:33:51 INFO - 30 libX11.so.6.3.0 + 0x148000
[task 2017-12-07T15:33:51.713Z] 15:33:51 INFO - eip = 0xf6605000 esp = 0xffe6a5e0 ebp = 0xdbbae400
[task 2017-12-07T15:33:51.714Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.719Z] 15:33:51 INFO - 31 libX11.so.6.3.0 + 0x3923a
[task 2017-12-07T15:33:51.720Z] 15:33:51 INFO - eip = 0xf64f623a esp = 0xffe6a5f0 ebp = 0xdbbae400
[task 2017-12-07T15:33:51.720Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.721Z] 15:33:51 INFO - 32 libpthread-2.23.so + 0x9c7b
[task 2017-12-07T15:33:51.722Z] 15:33:51 INFO - eip = 0xf7775c7b esp = 0xffe6a5fc ebp = 0xffe6a61c
[task 2017-12-07T15:33:51.723Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.724Z] 15:33:51 INFO - 33 0xf7196000
[task 2017-12-07T15:33:51.725Z] 15:33:51 INFO - eip = 0xf7196000 esp = 0xffe6a624 ebp = 0x00000000
[task 2017-12-07T15:33:51.727Z] 15:33:51 INFO - Found by: previous frame's frame pointer
[task 2017-12-07T15:33:51.727Z] 15:33:51 INFO - 34 libxul.so!_fini + 0x15c68ad
[task 2017-12-07T15:33:51.728Z] 15:33:51 INFO - eip = 0xf5003709 esp = 0xffe6a630 ebp = 0x00000000
[task 2017-12-07T15:33:51.729Z] 15:33:51 INFO - Found by: stack scanning
[task 2017-12-07T15:33:51.730Z] 15:33:51 INFO - 35 libxcb.so.1.1.0 + 0x25000
[task 2017-12-07T15:33:51.731Z] 15:33:51 INFO - eip = 0xf5c20000 esp = 0xffe6a65c ebp = 0xffe6a67c
[task 2017-12-07T15:33:51.732Z] 15:33:51 INFO - Found by: stack scanning
Flags: needinfo?(stransky)
|
|
Assignee | |
Comment 13•7 years ago
|
||
Thanks. I believe this one is correct as try looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d49e25615c5e
so re-landing this one.
Flags: needinfo?(stransky)
|
|
||
Comment 14•7 years ago
|
||
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/296dd5f8849a
Split clipboard implementation to shared (nsClipboard) and backend specific (nsClipboardX11) parts, r=jhorak
|
||
Comment 15•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•