Closed Bug 1418244 Opened 7 years ago Closed 7 years ago

Missing headers in MSE SourceBufferResource and TrackBuffersManager

Categories

(Core :: Audio/Video: Playback, enhancement)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(1 file, 1 obsolete file)

v1
(deleted), patch
cpearce
: review+
Details | Diff | Splinter Review
This causes build issues in non-unified builds.
Assignee: nobody → ferjmoreno
Attached patch v1 (obsolete) (deleted) — — Splinter Review
Attachment #8929391 - Flags: review?(cpearce)
Summary: MSE SourceBufferResource uses AbstractThread without including its header → Missing headers in MSE SourceBufferResource and TrackBuffersManager
TrackBuffersManager uses ErrorResult without including its header as well.
Attached patch v1 (deleted) — — Splinter Review
Attachment #8929391 - Attachment is obsolete: true
Attachment #8929391 - Flags: review?(cpearce)
Attachment #8929535 - Flags: review?(cpearce)
Attachment #8929535 - Flags: review?(cpearce) → review+
Note: trivial reviews like these on mediasource code if fine for me to do, but anything non-trivial should be reviewed by jya.
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/29ba2924db2f Add missing headers to MSE SourceBufferResource and TrackBuffersManager. r=cpearce
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/29ba2924db2f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: