Closed Bug 1418512 Opened 7 years ago Closed 7 years ago

Move xpfe autocomplete component to comm-central suite

Categories

(SeaMonkey :: Location Bar, enhancement)

Product:
SeaMonkey
Component:
Location Bar
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.56 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.56
Tracking Flags:
Tracking Status
seamonkey2.56 --- fixed

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.17)

User Story

See also Bug 1288981 but I changed the procedure a little

script copyfrommc.sh

1.) Create a temporary repo autocomplete
2.) Use hg convert with filemap autocomplete.map to fill the temporary repo with the contents of xpfe/components/autocomplete. Rename to suite/common/autocomplete in the repo. This took a looong time.
3.) switch to target comm-central repo for the push
4.) run repo_copy.sh and splice the temporary repo into the comm-central repo. Very fast so comm-central does not need to be closed for pushes. Can be repeated. 
Use autocomplete-tgt.map as a map but this can probably be omitted because no rename neccessary.

Attachments

(6 files, 3 obsolete files)

repo_copy.sh
(deleted), application/x-shellscript
Details
copyfrommc.sh
(deleted), application/x-shellscript
Details
autocomplete.map
(deleted), text/plain
Details
autocomplete-tgt.map
(deleted), text/plain
Details
1418512-mc-move.patch
(deleted), patch
Details | Diff | Splinter Review
1418512-autocomplete-finish-V2.patch
(deleted), patch
frg
: review+
frg
: feedback+
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1417119 +++ The autocomplete bindings and associated CSS in xpfe/components/autocomplete/ are used in mozilla-central, but they are used in comm-central suite and owned by suite. I suggest we move the code from m-c to c-c. Thread: https://groups.google.com/d/msg/mozilla.dev.platform/EoJkW2qQIQQ/ao71CndwBwAJ This is only used for the location bar in SeaMonkey. Everything else should use the toolkit autocomplete.
Well, Open web location use it and IIRC it's used in composer/mailnews too.
Attached file repo_copy.sh (deleted) —
Attached file copyfrommc.sh (deleted) —
Attached file autocomplete.map (deleted) —
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Attached file autocomplete-tgt.map (deleted) —
Ian the resulting temporary repo is about 10 MB in size. Do you think other paths should be exported too. Do you agree with the procedure or would you like to do it as in bug 1288981?
User Story: (updated)
Flags: needinfo?(iann_bugzilla)
Attached patch 1418512-wip.patch (obsolete) (deleted) — — Splinter Review
Result of hg convert for testing only.
Attached patch 1418512-wip.patch (obsolete) (deleted) — — Splinter Review
Actual patch to make this work in SeaMonkey. Should we move it from global to communicator?
Attached patch 1418512-mc-move.patch (deleted) — — Splinter Review
Result of hg convert for testing only.
Attachment #8929833 - Attachment is obsolete: true
If possible I would want to flatten the structure (i.e. remove the resources/content) so that everything is sitting in suite/common/autocomplete (In reply to Frank-Rainer Grahl (:frg) from comment #8) > Created attachment 8929834 [details] [diff] [review] > 1418512-wip.patch > > Actual patch to make this work in SeaMonkey. Should we move it from global > to communicator? Where do our other common bindings live? Consistency if there is any.
Flags: needinfo?(iann_bugzilla)
Attached patch 1418512-autocomplete-finish.patch (obsolete) (deleted) — — Splinter Review
Did a final rename in the patch. I think it is better if only the final 2 files are moved after the history is imported. Otherwise just let me know. I think the locations are fine now. Some global bindings are in common/bindings but the specific ones are in the subdirs. Stefan what do you think?
Attachment #8929834 - Attachment is obsolete: true
Attachment #8930244 - Flags: review?(iann_bugzilla)
Attachment #8930244 - Flags: feedback?(stefanh)
Comment on attachment 8930244 [details] [diff] [review] 1418512-autocomplete-finish.patch It's either common/autocomplete or common/bindings. But, as you say, this one is specific and it has it's own css file, so I think common/autocomplete makes sense. But why don't you use the jar.mn file in common/?
Attachment #8930244 - Flags: feedback?(stefanh) → feedback+
Comment on attachment 8930244 [details] [diff] [review] 1418512-autocomplete-finish.patch Agreed, shouldn't need a separate jar.mn r=me with that addressed
Attachment #8930244 - Flags: review?(iann_bugzilla) → review+
patch with jar.mn and moz.build removed. r+ from IanN and f+ from stefanh retained. Ok with me putting it and the autocomplete history in the tree?
Attachment #8930244 - Attachment is obsolete: true
Flags: needinfo?(iann_bugzilla)
Attachment #8931033 - Flags: review+
Attachment #8931033 - Flags: feedback+
Flags: needinfo?(iann_bugzilla)
Summary: Move xpfe autocomplete component too comm-central suite → Move xpfe autocomplete component to comm-central suite
Go for it!
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/b7db773f2a43 Move xpfe autocomplete to comm-central suite. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
status-seamonkey2.56: --- → fixed
Target Milestone: --- → Seamonkey2.56
https://hg.mozilla.org/comm-central/pushloghtml?changeset=85eb5dd6d56ac9bef58264480fd924c8ef190b97 Pulsebot updated the bugs in the history. Thankfully only "147" changesets. If we do this again we need to turn off pulsebot before the push.
Blocks: 1831187
Whiteboard: SM2.53.17
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: