Closed Bug 1418522 Opened 7 years ago Closed 7 years ago

Show unmatched candidates on about:webrtc

Categories

(Core :: WebRTC, defect, P2)

58 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This was supposed to already be in the ICE Stats table on about:webrtc, but the type field was slightly different (local-candidate or remote-candidate) vs the object field name on the page (localcandidate or remotecandidate).
Comment on attachment 8929660 [details] Bug 1418522 - fix unmatched ICE candidate handling on about:webrtc. https://reviewboard.mozilla.org/r/200940/#review206164 LGTM, with one comment. ::: toolkit/content/aboutwebrtc/aboutWebrtc.js:754 (Diff revision 1) > } > stats.push(stat); > } > } > > - for (let c of candidates.values()) { > + // add the unmatched candidates to the end of the table Another option here is something like: [...candidates.values()].filter(cnd => matched[cnd.id]).forEach( cand => stats.push{[cand.type]: this.candidateToString(cand)}); Which reads left to right, just an idea.
Attachment #8929660 - Flags: review?(na-g) → review+
Comment on attachment 8929660 [details] Bug 1418522 - fix unmatched ICE candidate handling on about:webrtc. https://reviewboard.mozilla.org/r/200940/#review206402 Ship it!
Pushed by mfroman@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/bdec8ddab580 fix unmatched ICE candidate handling on about:webrtc. r=ng
I've added the lint pre-commit hook to my .hgrc file now. :-)
Flags: needinfo?(mfroman)
Pushed by mfroman@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/ff6ab6ec5d18 fix unmatched ICE candidate handling on about:webrtc. r=ng
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: