Closed
Bug 1418851
Opened 7 years ago
Closed 7 years ago
nsDisplayList::Count() doc incorrectly states that it is "linear time" but it is now constant
Categories
(Core :: Web Painting, defect)
Core
Web Painting
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: mozbugz, Assigned: mozbugz)
References
Details
Attachments
(1 file)
Bug 1404181 modified nsDisplayList::Count() from a linear-time algorithm (going through the list item by item) to constant-time (just returning the known length).
But the comment above the function declaration still states that it is "linear time".
For bonus points, the definition could probably be inlined.
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → gsquelart
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8930259 [details]
Bug 1418851 - Inlined constant-time definition of nsDisplayItem::Count() -
https://reviewboard.mozilla.org/r/201388/#review206526
Attachment #8930259 -
Flags: review?(matt.woodrow) → review+
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67aa5b9539e8
Inlined constant-time definition of nsDisplayItem::Count() - r=mattwoodrow
|
|
Assignee | |
Comment 4•7 years ago
|
||
Thank you Matt for the quick review.
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•