Closed Bug 1419462 Opened 7 years ago Closed 6 years ago

getAllFlexbox traverseFrames argument is misleading

Categories

(DevTools :: Inspector, enhancement, P3)

Product:
DevTools
Component:
Inspector
Version:
58 Branch
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: jdescottes, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Whiteboard: [designer-tools])

Same issue as getAllGrids, the traverseFrames argument in getAllFlexbox [1] is not needed to traverse frames. If it is set to false, the tree walker will still traverse frames. I'll wait until the getAllGrids fix gets reviewed and landed in Bug 1403871 before applying the same strategy here. Note, this API is currently unused. https://searchfox.org/mozilla-central/rev/919dce54f43356c22d6ff6b81c07ef412b1bf933/devtools/server/actors/layout.js#181
Assignee: nobody → gl
Blocks: dt-flexbox
Status: NEW → ASSIGNED
Priority: -- → P3
Resolving this since we actually already removed getAllFelxbox
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
Product: Firefox → DevTools
Blocks: 1470379
You need to log in before you can comment on or make changes to this bug.