Ed Lee :Mardak Assignee
	Description • 7 years ago

[Tracking Requested - why for this release]: Sadness for "id". See attachment.

We added an exception to .gitignore in bug 1412930 but forgot to update it when files moved in bug 1413550. :(

The added files are those that would have been updated as part of bug 1415812.

	Ed Lee :Mardak Assignee
	Comment 2 • 7 years ago

Putting some dates into context:

Bug 1413550 regressed this and made it to Nightly 58 mozilla-central 18 days ago on November 4th.
Beta 58.0b1 went to aurora channel November 7th.
Beta 58.0b3 went to beta channel less than a week ago November 15th.

We're looking through activity stream's telemetry to see if this drop in "id" usage can be detected, and hopefully if so, we can put up some monitoring / alerts for this type of failure. (In addition to the unit test added here.)

	Francesco Lodolo [:flod]
	Comment 3 • 7 years ago

Adding a few Indonesian localizers, so they are aware of the issue in case they see support requests.

	rodin
	Comment 4 • 7 years ago

Thanks for putting this. I just realized this a few nights ago when my Indonesian Nightly stopped working on every new tab opened, while my other languages (de, en-US) Nightly seems fine.

	Kate Hudson :k88hudson
	Comment 5 • 7 years ago
mozreview-review

Comment on attachment 8930753 [details]
Bug 1419601 - Indonesian Bahasa Indonesia "id" builds have broken new tab pages.

https://reviewboard.mozilla.org/r/201850/#review207454

Good idea with that test. Looks good

	Pulsebot
	Comment 6 • 7 years ago

Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/20bc0a541fe9
Indonesian Bahasa Indonesia "id" builds have broken new tab pages. r=k88hudson

	Julien Cristau [:jcristau]
	Comment 7 • 7 years ago

Sounds bad, marking as blocker for 58.  Gerry fyi.

	Stefan Hindli [:stefan_hindli]
	Comment 8 • 7 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/20bc0a541fe9

	Ed Lee :Mardak Assignee
	Comment 9 • 7 years ago

Romi, the latest Nightly 59 update should be available now (20171122220056). Could you try updating nightly to verify if this has been fixed?

	Ed Lee :Mardak Assignee
	Comment 10 • 7 years ago

We'll be tracking adding monitoring of locale usage in https://github.com/mozilla/activity-stream/issues/3878

	rodin
	Comment 11 • 7 years ago

(In reply to Ed Lee :Mardak from comment #9)
> Romi, the latest Nightly 59 update should be available now (20171122220056).
> Could you try updating nightly to verify if this has been fixed?

20171122220056 has fixed this problem.
Thanks!

	Ed Lee :Mardak Assignee
	Comment 12 • 7 years ago

Comment on attachment 8930753 [details]
Bug 1419601 - Indonesian Bahasa Indonesia "id" builds have broken new tab pages.

Approval Request Comment
[Feature/Bug causing the regression]: Activity Stream startup optimization bug 1413550
[User impact if declined]: Indonesian users see failed load page for new tabs. See attachment 8930749 [details]
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes 20171122220056
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1415812 implements the functionality used by the html "id" content in this patch.
[Is the change risky?]: Not really
[Why is the change risky/not risky?]: Adds back the missing locale files that behave the same as the other locales that were correctly packaged.
[String changes made/needed]: Changed yes, needed no. These are the "id" strings.

	Ed Lee :Mardak Assignee
	Comment 13 • 7 years ago

This is the mozilla-central change rebased to mozilla-beta and export of https://github.com/mozilla/activity-stream/tree/firefox-58b2

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41be7003b085ec8e59807960f5565a3778bf5244

	Gerry Chang [:gchang]
	Comment 14 • 7 years ago

Hi :Mardak,
Are there errors ignorable per comment #13?

	Ed Lee :Mardak Assignee
	Comment 15 • 7 years ago

They should be. Do you see those errors in other uplift requests? In particular there's one that says "A failure in this test is considered a release blocker." But this change shouldn't be causing that.

	Ed Lee :Mardak Assignee
	Comment 16 • 7 years ago

andreio, can you answer comment 14?

	Tim Spurway [:tspurway]
	Comment 17 • 7 years ago

Let's please remember that Indonesia is completely broken in 58 Beta.

For sure.

Are we asking if this patch breaks some edge case in our test cases, when we know for a fact that a country with millions of Firefox Beta users are experiencing a broken about:newtab and about:home experience?

Please, let's uplift this patch.

	Gerry Chang [:gchang]
	Comment 18 • 7 years ago

Comment on attachment 8933040 [details] [diff] [review]
rebased export for mozilla-beta

This is a critical blocker for Indonesia. Beta58+.

	Gerry Chang [:gchang]
	Comment 19 • 7 years ago

NI :flod, not sure if the patch includes the string changes. Need :flod's help.

	Francesco Lodolo [:flod]
	Comment 20 • 7 years ago

No impact of strings, they're localized outside of m-c. Good to uplift.

	Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)
	Comment 21 • 7 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/22a20bb50c44

	Ed Lee :Mardak Assignee
	Comment 22 • 7 years ago

I grabbed an "id" build from mozilla-beta:
https://archive.mozilla.org/pub/devedition/candidates/58.0b8-candidates/build1/mac/id/Firefox%2058.0b8.dmg

Looks like it includes the fix from this bug:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&filter-searchStr=l10n&fromchange=27dc691eb4a0e52b7da1d69f6b6dcf8bfbaef759&tochange=c323f2b265dba7bc3886a4f54839535ef814d4fa