Closed Bug 1419755 Opened 7 years ago Closed 5 years ago

Formatted code does not respect indent width.

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox76 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: zyouhousikaku, Assigned: davidwalsh)

References

Details

Attachments

(1 file)

Bug 1419755 - Make debugger editor use indent size set by settings r=jlast
(deleted), text/x-phabricator-request
Details
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:59.0) Gecko/20100101 Firefox/59.0 Build ID: 20171122103138 Steps to reproduce: 1. Set to indent width other than 2 in settings of devtool. 2. format source code in debugger. 3. formatted source code indent width be 2 despite set to other than 2. Actual results: Indent width always become 2 despite set to other than 2 Expected results: Source code formatter should respect indent width setting
Component: Untriaged → Developer Tools: Debugger
Product: Firefox → DevTools
Blocks: dbg-prettyprint-m2
Priority: -- → P3

This is still an issue and would be nice to have.

Blocks: dbg-72
Assignee: nobody → dwalsh
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d94f9ef232a Make debugger editor use indent size set by settings r=jlast

Backed out changeset 8717adb8b05b (bug 1419755) for causing node debugger failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=295427570&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=1d94f9ef232a9431cb0ed751d9e8582c5ae96d0b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295427570&repo=autoland&lineNumber=1114

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=295436589&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=7f9f804e9dbe81bce013bf4dea28074744b568f6

[task 2020-03-30T18:38:57.027Z]   ● sources - pretty print › returns a pretty source for a minified file
[task 2020-03-30T18:38:57.027Z] 
[task 2020-03-30T18:38:57.027Z]     expect(received).toEqual(expected)
[task 2020-03-30T18:38:57.027Z] 
[task 2020-03-30T18:38:57.027Z]     Expected value to equal:
[task 2020-03-30T18:38:57.027Z]       "text/javascript"
[task 2020-03-30T18:38:57.027Z]     Received:
[task 2020-03-30T18:38:57.027Z]       false
[task 2020-03-30T18:38:57.027Z] 
[task 2020-03-30T18:38:57.027Z]     Difference:
[task 2020-03-30T18:38:57.027Z] 
[task 2020-03-30T18:38:57.027Z]       Comparing two different types of values. Expected string but received boolean.
[task 2020-03-30T18:38:57.027Z] 
[task 2020-03-30T18:38:57.027Z]       38 |         content.value.type === "text" &&
[task 2020-03-30T18:38:57.027Z]       39 |         content.value.contentType
[task 2020-03-30T18:38:57.027Z]     > 40 |     ).toEqual("text/javascript");
[task 2020-03-30T18:38:57.027Z]          |       ^
[task 2020-03-30T18:38:57.027Z]       41 |     expect(content).toMatchSnapshot();
[task 2020-03-30T18:38:57.027Z]       42 |   });
[task 2020-03-30T18:38:57.027Z]       43 | 
[task 2020-03-30T18:38:57.027Z] 
[task 2020-03-30T18:38:57.027Z]       at Object.toEqual (src/actions/sources/tests/prettyPrint.spec.js:40:7)
[task 2020-03-30T18:38:57.027Z]       at asyncGeneratorStep (src/actions/sources/tests/prettyPrint.spec.js:11:103TEST-UNEXPECTED-FAIL jest |   ● breakpoints › should remap breakpoints on pretty print
[task 2020-03-30T18:38:57.027Z] TEST-UNEXPECTED-FAIL jest |   ● project text search › should ignore sources with minified versions
[task 2020-03-30T18:38:57.027Z] TEST-UNEXPECTED-FAIL jest |   ● sources - pretty print › returns a pretty source for a minified file
[task 2020-03-30T18:38:57.027Z] TEST START | Stylelint
[task 2020-03-30T18:38:58.803Z] yarn run v1.9.4
[task 2020-03-30T18:38:58.803Z] $ stylelint "src/components/**/*.css"
[task 2020-03-30T18:38:58.803Z] Done in 1.42s.
Flags: needinfo?(dwalsh)
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ca29951b884f Make debugger editor use indent size set by settings r=jlast

https://hg.mozilla.org/mozilla-central/rev/ca29951b884f

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Flags: needinfo?(dwalsh)
QA Whiteboard: [qa-76b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: