Comment on attachment 8931287 [details] Bug 1419801 - Update Debugger Frontend (11-22). jdescottes, jlast https://reviewboard.mozilla.org/r/202434/#review207780 Looks good to me. Weirdly those big debugger bundle patches seem to fare better on splinter (the basic Bugzilla attachment review tool) than on mozreview :) No new regression spotted. R+ with a green try. ::: devtools/client/debugger/new/README.mozilla:4 (Diff revision 1) > This is the debugger.html project output. > See https://github.com/devtools-html/debugger.html > > -Taken from upstream commit: d2e91e574acbe3d5b546508d028bd278eaabd286 > +Taken from upstream commit: 3741eeb267fd2f0a1b42107389e31d3887798957 It's great that rev 3741eeb267fd2f0a1b42107389e31d3887798957 is a changeset from debugger.html master's branch! (and sadly I just realized that whatever commit was used for the previous release did not make it to master)

10x try run using this command: ./mach try -b do -p linux64,macosx64,win32,win64 -u mochitest-clipboard-e10s,mochitest-e10s-dt -t none --rebuild 10 devtools/client/debugger/new change sets: https://hg.mozilla.org/try/rev/d489be7113fe5252c448b7a14786dc62b8a27a7e https://hg.mozilla.org/try/rev/b7e12a09224a38e8ebe26214af438d1ea7b5e105 https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7e12a09224a38e8ebe26214af438d1ea7b5e105 try run using this command: ./mach try -b do -p linux64 -u mochitest-dt,mochitest-e10s-devtools-chrome,mochitest-o -t none --artifact change sets: https://hg.mozilla.org/try/rev/d756d13b3174a57af892d8d2fb0b19d61254c64d https://treeherder.mozilla.org/#/jobs?repo=try&revision=d756d13b3174a57af892d8d2fb0b19d61254c64d

I tracked the bundle increase to the parse-script-tags dependency, which we have to find scripts in HTML files. https://github.com/ryanjduffy/parse-script-tags/issues/6 I don't think the bundle size increase should be a blocker. We should try to address it soon in a release this week or next though.

(In reply to Jason Laster [:jlast] from comment #4) > I tracked the bundle increase to the parse-script-tags dependency, which we > have to find scripts in HTML files. > https://github.com/ryanjduffy/parse-script-tags/issues/6 > > I don't think the bundle size increase should be a blocker. We should try to > address it soon in a release this week or next though. The blocker right now is the permafail of some console tests in Debug : https://treeherder.mozilla.org/#/jobs?repo=try&revision=d756d13b3174a57af892d8d2fb0b19d61254c64d

fixed the memory leak, looks like a new dependency was the culprit. waiting for try to pass and then checking in https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffc0900336650ec063f51d39a8956f0c3a533abd https://treeherder.mozilla.org/#/jobs?repo=try&revision=6179a8aa26520db99c0d939fe129ef8e15607471

Great! Can you make sure the commit message is properly formatted? The last patch on mozreview has "bug 1419801 - update 11-22", the initial patch had "Bug 1419801 - Update Debugger Frontend (11-22). jdescottes, jlast"

updated!

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eeaa1ed4ac8c Update Debugger Frontend (11-22). jdescottes, jlast r=jdescottes