Closed Bug 1419935 Opened 7 years ago Closed 7 years ago

Remove the "menulist-description" binding

Categories

(Core :: XUL, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox58 --- wontfix
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: bgrins, Assigned: 36198)

References

Details

(Whiteboard: [xbl-available])

Attachments

(1 file)

The menu-vertical binding (bound to menulist[type=description]) appears to be unused in m-c: https://searchfox.org/mozilla-central/search?q=type%3D%22description%22&path=xul The binding, along with any associated CSS can be removed: https://searchfox.org/mozilla-central/search?q=menulist-description&path=. Note that there is a single consumer in comm-central, so either that will have to become a plain menulist or the binding will need to be migrated there to continue working: https://searchfox.org/comm-central/search?q=type%3D%22description%22&path=xul. It appears that the difference (some extra flex and different styling) could be migrated as CSS-only and not require porting the binding.
Priority: -- → P5
Attached patch bug.patch (deleted) — Splinter Review
Attachment #8944590 - Flags: review?(bgrinstead)
Depends on: 1432592
Assignee: nobody → 36198
Status: NEW → ASSIGNED
Attachment #8944590 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/efb319fac7c3 Removed the unused menulist-description binding r=bgrins
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Component: XP Toolkit/Widgets: XUL → XUL
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: