Closed Bug 1419960 Opened 7 years ago Closed 6 years ago

Make the noopener window feature not affect whether other window features are enabled

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

53 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bzbarsky, Assigned: annyG)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

The spec is not making progress in https://github.com/whatwg/html/issues/1902 and it's causing sites real problems (e.g. see bug 1416728 comment 25). We should just unilaterally change our behavior here.
I agree - the current behaviour is unusable. We should make `window.open(url, "_blank", "noopener")` act exactly like `window.open(url, "_blank")` except that opener is not set.
Priority: -- → P2
Assignee: bzbarsky → agakhokidze
Comment on attachment 8992238 [details] Bug 1419960 - Make the noopener window feature not affect whether other window features are enabled, r=nika :Nika Layzell has approved the revision. https://phabricator.services.mozilla.com/D2150
Attachment #8992238 - Flags: review+
Pushed by nlayzell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7122e56941ef Make the noopener window feature not affect whether other window features are enabled, r=nika
Please send an intent to ship for this? We should probably do something similar for noreferrer too, right?
Flags: needinfo?(nika)
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #5) > Please send an intent to ship for this? Anny, would you write up an intent to ship (https://wiki.mozilla.org/ExposureGuidelines#Intent_to_ship) - I can help you look over it before we send it to dev-platform. > We should probably do something similar for noreferrer too, right? IIRC we don't allow "noreferrer" as a window.open flag, but rather only allow it as a rel="" attribute. When it's used in that way it's already stripped out of the features string by nsDocShell::InternalLoad.
Flags: needinfo?(nika) → needinfo?(agakhokidze)
> IIRC we don't allow "noreferrer" as a window.open flag Ah, ok. I saw it in the test the patch for this bug modifies, but maybe there it's basically acting just like "nosuchflag" would...
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
I sent out an Intent to ship email to dev-platform (also see here https://groups.google.com/forum/#!topic/mozilla.dev.platform/6cTk_b1l6LE)
Flags: needinfo?(agakhokidze)
Probably worth making a note about this somewhere.
Keywords: dev-doc-needed
Filed PR to update compat table for rel="noopener": https://github.com/mdn/browser-compat-data/pull/2748 And updated: https://developer.mozilla.org/en-US/docs/Web/API/Window/opener https://developer.mozilla.org/en-US/docs/Web/API/Window/open (noopener under window features) And updated Firefox 63 for developers.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: