Ionuț Goldan [:igoldan] Reporter
	Description • 7 years ago

We have detected an autophone (Android) regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=db56323cd08f4883e4824199b441a3141be655e5

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  7%  remote-tsvg summary android-6-0-armv8-api16 opt      84.13 -> 89.63
  6%  remote-twitter summary android-7-1-armv8-api16 opt   774.07 -> 823.84
  6%  remote-tsvg summary android-7-1-armv8-api16 opt      102.84 -> 109.23


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=10710

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/EngineeringProductivity/Autophone

	Ionuț Goldan [:igoldan] Reporter
	Comment 1 • 7 years ago

:m_kato Looks like enabling Stylo on Android brought some perf regressions. Were these expected?

	Makoto Kato [:m_kato] Assignee
	Comment 2 • 7 years ago

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #1)
> :m_kato Looks like enabling Stylo on Android brought some perf regressions.
> Were these expected?

Yes and no.  But we need figure out why remote-tsvg is slow.  And, why does remote-twitter by android-6-0-armv8-api16 doesn't hit this?

	Chris Peterson [:cpeterson]
	Comment 3 • 7 years ago

P2 because we should address this regression before we ship stylo-android.

	Makoto Kato [:m_kato] Assignee
	Comment 4 • 7 years ago

Gecko profiler doesn't support android...

	Makoto Kato [:m_kato] Assignee
	Comment 5 • 7 years ago

twitter and gearflowers.svg have a long style attribute.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 6 • 7 years ago

Tracking for 59 since we're aiming to enable this feature on nightly 59.

	Andrew Overholt [:overholt]
	Comment 7 • 7 years ago

Are we still planning on shipping Stylo on Android in 59?

	Chris Peterson [:cpeterson]
	Comment 8 • 7 years ago

(In reply to Andrew Overholt [:overholt] from comment #7)
> Are we still planning on shipping Stylo on Android in 59?

Yes. Makoto thinks the NEON optimization patch in bug 586838 will fix this Android perf regression.

	Andrew Overholt [:overholt]
	Comment 9 • 7 years ago

[Tracking Requested - why for this release]:
Apparently stylo on android is slipping to 60

	Julien Cristau [:jcristau]
	Comment 10 • 6 years ago

AIUI we're not blocking stylo-android on this for 60, so I'll move this to fix-optional.

	James Willcox (:snorp) (jwillcox@mozilla.com) (he/him)
	Comment 11 • 6 years ago

Since bug 586838 landed, has this gotten better?

	Ionuț Goldan [:igoldan] Reporter
	Comment 12 • 6 years ago

(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #11)
> Since bug 586838 landed, has this gotten better?

Not really.

	Makoto Kato [:m_kato] Assignee
	Comment 13 • 6 years ago

(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #11)
> Since bug 586838 landed, has this gotten better?

not enough.  I guess that this is into cssparser and rust.

	David Bolter [:davidb] (NeedInfo me for attention)
	Comment 14 • 6 years ago

Looking at this during QF triage, Panos is this actionable? Maybe we can get a profile?

	Panos Astithas (he/him) [:past] (please ni?)
	Comment 15 • 6 years ago

(In reply to Makoto Kato [:m_kato] from comment #13)
> (In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #11)
> > Since bug 586838 landed, has this gotten better?
> 
> not enough.  I guess that this is into cssparser and rust.

Do you have a profile that shows this? If not, could you get one and share it here? Emilio or Xidorn could take a look if it is cssparser related.

	Makoto Kato [:m_kato] Assignee
	Comment 16 • 6 years ago

https://perfht.ml/2Ks8P1I

Since we don't use rust 1.27+ as build environment, walking stack on rust code isn't correct.  So profiler cannot get better data.

	Makoto Kato [:m_kato] Assignee
	Comment 17 • 6 years ago

(this data uses https://searchfox.org/mozilla-central/source/testing/talos/talos/tests/svg_static/gearflowers.svg)

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 18 • 6 years ago

Looks like this is still not actionable.

	Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)
	Comment 19 • 6 years ago

Letting this fall out of regression triage since it's had several wontfixes in a row.