Closed
Bug 1420791
Opened 7 years ago
Closed 7 years ago
Tidy up animation_utils.js
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(3 files)
In animation_utils.js there are some confusing about using waitForAllPaintsFlushed(). Say, waitForPaints() in runOMTATest() uses waitForAllPaintsFlushed(). We should tidy tidy them up.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 4•7 years ago
|
||
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8932009 [details]
Bug 1420791 - Use waitForPaintsFlushed() instead of waitForPaints().
https://reviewboard.mozilla.org/r/203064/#review208362
Attachment #8932009 -
Flags: review?(boris.chiou) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8932010 [details]
Bug 1420791 - Drop explicit flushing styles before calling waitForPaintsFlushed().
https://reviewboard.mozilla.org/r/203066/#review208364
Attachment #8932010 -
Flags: review?(boris.chiou) → review+
|
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8932011 [details]
Bug 1420791 - Drop waitForPaints() in runOMTATest().
https://reviewboard.mozilla.org/r/203068/#review208366
These patches make sense to me. Thanks.
Attachment #8932011 -
Flags: review?(boris.chiou) → review+
|
|
Assignee | |
Comment 8•7 years ago
|
||
Thank you as well!
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2df254db1313
Use waitForPaintsFlushed() instead of waitForPaints(). r=boris
https://hg.mozilla.org/integration/autoland/rev/9b2c659d7152
Drop explicit flushing styles before calling waitForPaintsFlushed(). r=boris
https://hg.mozilla.org/integration/autoland/rev/30264fec78cf
Drop waitForPaints() in runOMTATest(). r=boris
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2df254db1313
https://hg.mozilla.org/mozilla-central/rev/9b2c659d7152
https://hg.mozilla.org/mozilla-central/rev/30264fec78cf
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•