Closed Bug 1420925 Opened 7 years ago Closed 7 years ago

Some JS module error test cases concerning error identity are outdated

Categories

(Testing :: web-platform-tests, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

()

Details

Attachments

(1 file)

Created for this issue: https://github.com/w3c/web-platform-tests/issues/7747 When bug 1420420 lands a few tests will start to fail until they are updated to match the latest spec.
Update module tests that checked the identity of instantiation exceptions to check the message instead. The instantiation-error-3.html test often fails in our implementation for other reasons so I disabled this.
Assignee: nobody → jcoppeard
Comment on attachment 8937166 [details] [diff] [review] bug1420925-update-error-identity-tests Speculative r? jgraham. Feel free to reject and I'll find someone else.
Attachment #8937166 - Flags: review?(james)
Comment on attachment 8937166 [details] [diff] [review] bug1420925-update-error-identity-tests Review of attachment 8937166 [details] [diff] [review]: ----------------------------------------------------------------- I'm slightly guessing that the test changes are OK, but it seems reasonable. ::: testing/web-platform/meta/html/semantics/scripting-1/the-script-element/module/instantiation-error-3.html.ini @@ +1,2 @@ > [instantiation-error-3.html] > + disabled: often fails Usually we link this to a bug number
Attachment #8937166 - Flags: review?(james) → review+
I filed bug 1426195 for the instantiation-error-3.html failures.
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9928b5dffb3f Update JS module tests now that repeated instantiation failures of a module are no longer required to throw the same value r=jgraham
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: