Closed Bug 1421151 Opened 7 years ago Closed 7 years ago

Fix the failure on test_animation_performance_warning.html with conformant Promise handling on Android

Categories

(Core :: DOM: Animation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file)

There is a horrible mistake that we call start() twice[1][2] to run all test cases! So actually we've been running whole test twice each run.:/ And the twice run interferes other running test cases somehow with the conformant Promise handling. [1] https://hg.mozilla.org/mozilla-central/file/f5f03ee9e6ab/dom/animation/test/chrome/test_animation_performance_warning.html#l37 [2] https://hg.mozilla.org/mozilla-central/file/f5f03ee9e6ab/dom/animation/test/chrome/test_animation_performance_warning.html#l1298 Here is a try with dropping the one call; https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3822d7b0b4981ddfd0f3a3ec52690c5c0e5160f In this try, test_animation_performance_warning.html took 70805ms on Android opt build, whereas it took 134372ms on Android opt build without the fix. :)
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
Comment on attachment 8932351 [details] Bug 1421151 - Drop redundant calling start(). https://reviewboard.mozilla.org/r/203394/#review208834 Wow, nice find.
Attachment #8932351 - Flags: review?(bbirtles) → review+
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cff54d05bcad Drop redundant calling start(). r=birtles
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: