Closed Bug 1421259 Opened 7 years ago Closed 7 years ago

Too many events fired for JS module load errors

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

We currently currently fire an error event for every module dependency that fails to load in a module graph. We should only fire a single event.
The first change is to make ScriptLoader::OnStreamComplete not fire an event for non-top-level modules. However now we have to make sure top-level modules also fire error events. Currently, inline script elements don't fire error events (because there can never be an error fetching an inline script). I was unsure of the best way to do this. What I've done here is to change the aIsInline parameter to ScriptElement::ScriptAvailable to aIsInlineClassicScript, because that is the test that we want to make. This works but it isn't great because it leaks into the nsIScriptLoaderObserver interface. Is this is OK or do you think there is there a better way to do this?
Attachment #8932466 - Flags: review?(amarchesini)
Blocks: 1393429
Priority: -- → P3
Attachment #8932466 - Flags: review?(amarchesini) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aaf6dde0deb8 Fix error events fired when loading JS module dependencies fail r=baku
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: