Closed
Bug 1421351
Opened 7 years ago
Closed 7 years ago
scrollend event should be posted to refresh driver scroll event queue
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file)
In bug 1172171, I added a very simple mechanism to fire a chrome-only "scrollend" event when scrolling ends on an nsGfxScrollFrame.
That mechanism worked by waiting until nsGfxScrollFrame had computed that scrolling had completed, and just firing the event at that point.
The problem is that "scroll" events are fired by appending them to a queue that the refresh driver flushes periodically off of frame ticks.
This means we could get into cases where we'd fire a scrollend event, and then the refresh driver would flush more scroll events after the fact.
We should probably append scrollend events to the refresh driver queue instead of firing them immediately.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → mconley
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8932567 [details]
Bug 1421351 - Queue chrome-only scrollend event in refresh driver scroll event queue instead of firing immediately.
https://reviewboard.mozilla.org/r/203624/#review209070
Looks reasonable to me. Were you able to confirm that this solves the problem you were seeing?
Attachment #8932567 -
Flags: review?(bugmail) → review+
Assignee | ||
Comment 3•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8932567 [details]
Bug 1421351 - Queue chrome-only scrollend event in refresh driver scroll event queue instead of firing immediately.
https://reviewboard.mozilla.org/r/203624/#review209070
Yep, I was able to confirm with a bunch of logging. I tested both the mousewheel and trackpad case.
Assignee | ||
Comment 4•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8932567 [details]
Bug 1421351 - Queue chrome-only scrollend event in refresh driver scroll event queue instead of firing immediately.
https://reviewboard.mozilla.org/r/203624/#review209070
Thanks for the fast review!
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b7d7bb45c063
Queue chrome-only scrollend event in refresh driver scroll event queue instead of firing immediately. r=kats
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•