Closed
Bug 1421444
Opened 7 years ago
Closed 7 years ago
Fix sass linting
Categories
(Firefox :: New Tab Page, defect, P3)
Firefox
New Tab Page
Tracking
()
People
(Reporter: Mardak, Assigned: u594638, Mentored)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
text/x-github-pull-request
|
Details |
No description provided.
|
Reporter | |
Updated•7 years ago
|
status-firefox58:
--- → wontfix
|
||
Comment 1•7 years ago
|
||
:Mardak more recently updated this into https://github.com/mozilla/activity-stream/pull/3871, which is currently marked as blocked in github (for unclear reasons) and has a few conflicts. My recollection of our Monday meeting was that it needs to be fixed up to catch a few more errors and then can be reviewed. Or is there some additional reason it was blocked?
|
|
||
Updated•7 years ago
|
Flags: needinfo?(edilee)
|
|
Reporter | |
Comment 2•7 years ago
|
||
It was rebased on top of a sass-lint update, which hasn't been merged yet.
Flags: needinfo?(edilee)
I'd like to continue off where we left off from the issue on GitHub - please let me know where I may begin again!
|
|
Reporter | |
Updated•7 years ago
|
Assignee: dmose → S.Prashad
Mentor: dmose
Whiteboard: [assigned to contributor]
|
||
Comment 4•7 years ago
|
||
|
|
Reporter | |
Updated•7 years ago
|
Attachment #8933030 -
Attachment is obsolete: true
|
|
||
Comment 5•7 years ago
|
||
|
|
Reporter | |
Comment 6•7 years ago
|
||
Sean, I've already updated your PR/commits on top of the latest master, so unless there are review comments to address, it should be good to go! Thanks for your work in getting all of this done. :)
|
||
Comment 7•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/6c92c7c8601acf7493946d34c92fa497cb764b3c
fix(styles): Enable sass-lint and fix errors
Fix Bug 1421444 - Fix sass linting
|
|
||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 8•7 years ago
|
||
Target Milestone: --- → Firefox 59
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•