Closed Bug 1421857 Opened 7 years ago Closed 7 years ago

test-merges.js (pine script) regressed by bug 1421823

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Iteration:
1.25
Tracking Flags:
Tracking Status
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: dmosedale, Assigned: dmosedale)

References

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/3888
(deleted), text/x-github-pull-request
Details
This is because node-github 9.0 (we upgrade from 8 to 12) has the following breaking change: Breaking changes: Always return a response as an object with data and meta attributes. Fix is straightforward.
Iteration: --- → 1.25
Status: NEW → ASSIGNED
status-firefox58: --- → unaffected
status-firefox59: --- → affected
Priority: -- → P1
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/321a79d454a3b592ba8d9377993f31a2324f3513 Fix Bug 1421857 - fix test-merges regression to un-bust pine https://github.com/mozilla/activity-stream/commit/b05326747e241b8d9a8d03d1633a2719b9e6acc0 Merge pull request #3888 from dmose/test-merges-fix Fix Bug 1421857 - fix test-merges regression to un-bust pine, r=Mardak
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1421917
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: